[Support] Support new model: Ross #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcz358
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Hi, thanks for the PR. I think the overall structure looks like llava and should be good to merge. If possible, can you post a screenshot for the evaluate result? And please try to fix the linting issue using pre-commit. Then I think I will merge it into main. Thanks!
|
Hi @kcz358, I have now fixed the linting issue, and here is the evaluation result. |
|
These new linting issues seem to be not related to this PR. How can I fix it? |
|
Hi, can you try rebase or merge from the main again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you open a pull-request, please be sure to include the following