Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests for solver examples #282

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

oparry-ukaea
Copy link
Contributor

@oparry-ukaea oparry-ukaea commented Jan 21, 2025

Description

Sets up a regressionTests gtest exec. A test is run for (almost) every examples/[solver_name]/[example_name] subdirectory.

Main additions are

  • a SolverRegTest gtest fixture (sub-classed for each solver)
  • a Python script to generate HDF5 regression data (reads example output and uses NekPy to generate "equispaced" points for each field.
  • Regression data at test/regression/examples/[solver_name]/[eg_name].regression_data.h5

Particle output ignored for now (so no test for Electrostatic2D3V/TwoStream yet).

Resolves #275.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Requires documentation updates

Testing

Existing unit, integration tests pass; new regression tests added.

Test Configuration:

  • OS: Ubuntu 22.04
  • Compiler: GCC 11.3.0 / OneAPI 2024.1.0
  • SYCL implementation: AdaptiveCpp 24.06.0 / DPC++ 2022.1.0
  • MPI details: MPICH 4.0.2 / Intel MPI 2021.8 Build 20221129
  • Hardware: CPU (Intel Raptor Lake)

Checklist:

- [ ] I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes
  • Any new dependencies are automatically built for users via cmake
  • I have used understandable variable names
  • I have run clang-format against my *.hpp and *.cpp changes
  • I have run cmake-format against my changes to CMakeLists.txt
    - [ ] I have run black against changes to *.py
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@oparry-ukaea oparry-ukaea force-pushed the feature/eg_regression_tests branch from 0484af1 to b8d3186 Compare February 5, 2025 12:34
@oparry-ukaea
Copy link
Contributor Author

Tests for SimpleSOL and Diffusion solver examples are working.
H3LAPD test work for 2DRogersRicci, but not for HW examples yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression tests for examples.
1 participant