-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression tests for solver examples #282
Draft
oparry-ukaea
wants to merge
32
commits into
main
Choose a base branch
from
feature/eg_regression_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…point values to hdf5.
…e used in SOLSystem too.
…output and compare to regression data.
…egression_data.py.
…ct "CombinedSolver".
0484af1
to
b8d3186
Compare
Tests for SimpleSOL and Diffusion solver examples are working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets up a regressionTests gtest exec. A test is run for (almost) every
examples/[solver_name]/[example_name]
subdirectory.Main additions are
test/regression/examples/[solver_name]/[eg_name].regression_data.h5
Particle output ignored for now (so no test for
Electrostatic2D3V/TwoStream
yet).Resolves #275.
Type of change
Testing
Existing unit, integration tests pass; new regression tests added.
Test Configuration:
Checklist:
- [ ] I have added tests that prove my fix is effective or that my feature workscmake
clang-format
against my*.hpp
and*.cpp
changescmake-format
against my changes toCMakeLists.txt
- [ ] I have runblack
against changes to*.py