simplify tests and check against new-ets branch #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Nov 25, 2023
lib/hammer_plug.ex
Outdated
| @@ -210,7 +214,8 @@ defmodule Hammer.Plug do | |||
| {:deny, _n} -> | |||
| on_deny_handler.(conn, []) | |||
|
|
|||
| {:error, _reason} -> | |||
| {:error, reason} -> | |||
| Logger.error(check_rate_fail_reason: reason) | |||
There was a problem hiding this comment.
This should raise an exception, I think. Plug would catch it, send 500, and then re-raise.
There was a problem hiding this comment.
In Hammer as well, I think {:error, reason}` return value can be removed in favor of an exception since it's unclear what should be done in that case, allow or deny.
ruslandoga
commented
Nov 25, 2023
mix.exs
Outdated
| {:hammer, "~> 6.0"}, | ||
| {:plug, "~> 1.0"}, | ||
| {:mock, "~> 0.3.0", only: :test} | ||
| {:hammer, github: "ruslandoga/hammer", branch: "new-ets"}, |
There was a problem hiding this comment.
Should be changed to ~> 7.0 once ExHammer/hammer#104 is merged.
ruslandoga
commented
Nov 25, 2023
| @@ -1 +1,2 @@ | |||
| {:ok, _apps} = Application.ensure_all_started([:plug]) | |||
There was a problem hiding this comment.
:plug doesn't need to be started since the tests are not using Plug.Upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks that the tests pass with changes in ExHammer/hammer#104
To actually make the tests check integration with Hammer I removed Mock.