-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate #36
Closed
Closed
Deprecate #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
commented
Nov 17, 2024
|
||
plug :#{plug_name} # when action in ... | ||
|
||
#{render_custom_plug(config) |> String.replace("\n", "\n ")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example warning:
15:54:07.496 [warning] Hummer.Plug is deprecated. Please consider replacing it with a function plug:
plug :rate_limit_video_upload # when action in ...
defp rate_limit_video_upload(conn, _opts) do
request_id = get_session(conn, :user_id)
# note that request_id might be nil
key = "video:upload:#{request_id}"
scale = 60000
limit = 10
case Hammer.check_rate(key, scale, limit) do
{:allow, _count} ->
conn
{:deny, _limit} ->
conn |> send_resp(429, "Too Many Requests") |> halt()
{:error, _reason} ->
conn |> send_resp(429, "Too Many Requests") |> halt()
end
end
epinault
reviewed
Dec 7, 2024
epinault
reviewed
Dec 7, 2024
@ruslandoga would it be helpful to chat in person ? I think we are misunderstanding each other you are misunderstanding my intention here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: ExHammer/hammer#104 (comment)