Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php 8.3 to build jobs #104

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Add php 8.3 to build jobs #104

merged 1 commit into from
Mar 8, 2024

Conversation

84m
Copy link
Contributor

@84m 84m commented Mar 8, 2024

Adding php8.3 to the current build jobs

@84m
Copy link
Contributor Author

84m commented Mar 8, 2024

Hey @HeahDude,
i would love approval here, to get the workflow running ;-)

@HeahDude
Copy link
Collaborator

HeahDude commented Mar 8, 2024

@84m thanks for the PR!
It seems we need to fix a bit more the workflow run on low deps, do you want to give it a try or do you want me to handle it by pushing on your branch (probably tomorrow)?

@84m
Copy link
Contributor Author

84m commented Mar 8, 2024

[...] do you want to give it a try or do you want me to handle it by pushing on your branch (probably tomorrow)?

sure, go ahead. I justed fixed the codestyle as a quick fix, but would also need to dig deeper on why the lowest-ci is currently failing.

@84m
Copy link
Contributor Author

84m commented Mar 8, 2024

short update: i think i found the issue

@HeahDude
Copy link
Collaborator

HeahDude commented Mar 8, 2024

Thank you @84m

@HeahDude HeahDude merged commit 19615c5 into Exercise:master Mar 8, 2024
13 checks passed
@84m 84m deleted the php-83 branch March 9, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants