Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve titles and Open Graph properties #619

Merged
merged 5 commits into from
Jun 1, 2024
Merged

Improve titles and Open Graph properties #619

merged 5 commits into from
Jun 1, 2024

Conversation

codeurimpulsif
Copy link
Contributor

@codeurimpulsif codeurimpulsif commented May 26, 2024

Goal

Common to all pages

  • Add Open Graph type: article
  • Add Open Graph site_name: εxodus
  • Add Open Graph image: default εxodus logo without text

Specific for each page

  • Add specific titles (with a fallback to εxodus)
  • Add Open Graph titles
  • Add description
  • Add Open Graph description

Information

Fix #59 and fix #142

with a fallback to "εxodus"
with type, site_name and image
@pnu-s
Copy link
Member

pnu-s commented May 27, 2024

Thanks a lot @codeurimpulsif 🥳

Is there a way to test how it would look before releasing this to product?

How could you test it?

If you can attach screenshots, please do :)

@codeurimpulsif
Copy link
Contributor Author

We can only check if values are correct, but each social network or website preview it the way it want, so preview is not very useful

@codeurimpulsif
Copy link
Contributor Author

@codeurimpulsif codeurimpulsif marked this pull request as ready for review June 1, 2024 01:48
Copy link
Member

@pnu-s pnu-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codeurimpulsif codeurimpulsif merged commit ff9c4b6 into v1 Jun 1, 2024
8 checks passed
@codeurimpulsif codeurimpulsif deleted the head-html branch June 1, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the public utility of exodus by improving its SEO twitter / facebook meta tags in report
2 participants