Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech: Minor code improvements #628

Merged
merged 1 commit into from
Sep 16, 2024
Merged

tech: Minor code improvements #628

merged 1 commit into from
Sep 16, 2024

Conversation

pnu-s
Copy link
Member

@pnu-s pnu-s commented Sep 14, 2024 •
edited
Loading

  • Remove obsolete attribute in docker compose
  • Make sure we close files we open (or do not open it twice)
  • Remove unnecessary conditions

codeurimpulsif
codeurimpulsif approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@codeurimpulsif codeurimpulsif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok for me, maybe request method can be set as function parameters?

@pnu-s
Copy link
Member Author

pnu-s commented Sep 15, 2024

@codeurimpulsif The request method is already set as a decorator (@api_view(['GET'])), that's why it does not make sense to have the extra condition

@codeurimpulsif
Copy link
Contributor

@pnu-s oh you're right, sorry, let's merge it!

@pnu-s pnu-s merged commit 4933a63 into v1 Sep 16, 2024
8 checks passed
@pnu-s pnu-s deleted the tweaks branch September 16, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeurimpulsif codeurimpulsif codeurimpulsif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnu-s @codeurimpulsif