Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add error logs #66

Merged
merged 2 commits into from
Jun 12, 2024
Merged

feat: add error logs #66

merged 2 commits into from
Jun 12, 2024

Conversation

headfire94
Copy link
Contributor

Summary

can't understand why asana complete task action fails. add logs to this an other places.

Copy link
Contributor

@federico-po federico-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does core.error support two args though?

It's really weird that this gets logged with accurate data but then it failed. Maybe you can try with a token and replicate the fetch locally?

@mvayngrib
Copy link
Collaborator

it does support 2 args, but you need to provide the right fields for the 2nd https://github.com/actions/toolkit/blob/main/packages/core/src/core.ts#L250-L259

@headfire94
Copy link
Contributor Author

updated

@headfire94
Copy link
Contributor Author

Maybe you can try with a token and replicate the fetch locally?

Probably issue is with token access. that what i want to know with error in logs

@sonaye
Copy link

sonaye commented Jun 7, 2024

Can we get this in, Asana linking is completely broken for us

Copy link
Contributor

@lanre-mark lanre-mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Adding the logs is fine but might be better to get a token to debug this

@lanre-mark
Copy link
Contributor

Might be necessary to introduce a retry logic here for instance. Could be ETIMEDOUT erorrs

@headfire94 headfire94 merged commit de9396b into main Jun 12, 2024
@headfire94 headfire94 deleted the egor/feat/add-logs branch June 12, 2024 13:59
@headfire94
Copy link
Contributor Author

@lanre-mark @federico-po it shows "Error while completing task(s) (1207629198924482). Error: Forbidden" now

@headfire94
Copy link
Contributor Author

Maybe you can try with a token and replicate the fetch locally?

No issues when trying to complete task (using https://developers.asana.com/reference/updatetask and personal token). @federico-po how to check what token is used for CI , maybe it doesn't have access?

@federico-po
Copy link
Contributor

maybe that's it - you should ask the repo owner (or someone with enough access to it).

The token needs to be in the repo config under ASANA_TOKEN variable

@headfire94
Copy link
Contributor Author

@farisissa8 do you know who is mobile repo owner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants