feat: adding config properties map for kafka consumer #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlegarda
changed the title
hlegarda
changed the title
patduin
reviewed
Oct 22, 2024
drone-fly-app/src/main/java/com/expediagroup/dataplatform/dronefly/app/context/CommonBeans.java
Outdated
Show resolved
Hide resolved
patduin
reviewed
Oct 23, 2024
drone-fly-app/src/main/java/com/expediagroup/dataplatform/dronefly/app/context/CommonBeans.java
Show resolved
Hide resolved
patduin
reviewed
Oct 23, 2024
patduin
reviewed
Oct 23, 2024
drone-fly-app/src/main/java/com/expediagroup/dataplatform/dronefly/app/context/CommonBeans.java
Outdated
Show resolved
Hide resolved
…f parameters to fill only with prefix params
hlegarda
changed the title
patduin
reviewed
Oct 23, 2024
drone-fly-app/src/main/java/com/expediagroup/dataplatform/dronefly/app/context/CommonBeans.java
Outdated
Show resolved
Hide resolved
patduin
reviewed
Oct 23, 2024
drone-fly-app/src/main/java/com/expediagroup/dataplatform/dronefly/app/context/CommonBeans.java
Show resolved
Hide resolved
…f parameters to fill only with prefix params
…f parameters to fill only with prefix params
…f parameters to fill only with prefix params
…f parameters to fill only with prefix params
patduin
approved these changes
Oct 23, 2024
githubjianli
approved these changes
Oct 23, 2024
githubjianli
merged commit 2881010
into
ExpediaGroup:kafka-cloud-provider-support
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Added a config properties map for allowing sending those properties to kafka consumer, allowing us to connect to kafka cloud providers