build: Explicit protobuf build version; consistent build/setup deps

.github/workflows/build_wheels.yml

@@ -97,7 +97,6 @@ jobs:
         # There's a `git restore` in here because `make install-go-ci-dependencies` is actually messing up go.mod & go.sum.
         run: |
           pip install -U pip setuptools wheel twine
-          make install-protoc-dependencies
           make build-ui
           git status
           git restore go.mod go.sum

Makefile

@@ -395,10 +395,8 @@ install-go-ci-dependencies:
 	go install github.com/go-python/gopy
 	python -m pip install "pybindgen==0.22.1" "protobuf>=4.24.0,<5"
 
-install-protoc-dependencies:
-	pip install --ignore-installed "protobuf>=4.24.0,<5" "grpcio-tools>=1.56.2,<2" mypy-protobuf==3.1.0
-
-compile-protos-go: install-go-proto-dependencies install-protoc-dependencies
+compile-protos-go: install-go-proto-dependencies
+	pip install --ignore-installed "protobuf==4.25.4" "grpcio-tools>=1.56.2,<2" mypy-protobuf==3.1
 	python setup.py build_go_protos
 
 install-feast-ci-locally:

environment-setup.md

@@ -13,7 +13,6 @@ pip install cryptography -U
 conda install protobuf
 conda install pymssql
 pip install -e ".[dev]"
-make install-protoc-dependencies PYTHON=3.9
 make install-python-ci-dependencies PYTHON=3.9
 ```
 4. start the docker daemon

protos/feast/registry/RegistryServer.proto

@@ -67,7 +67,7 @@ service RegistryServer{
   rpc Commit (google.protobuf.Empty) returns (google.protobuf.Empty) {}
   rpc Refresh (RefreshRequest) returns (google.protobuf.Empty) {}
   rpc Proto (google.protobuf.Empty) returns (feast.core.Registry) {}
-
+  
 }
 
 message RefreshRequest {

pyproject.toml

@@ -1,5 +1,15 @@
 [build-system]
-requires = ["setuptools>=60", "wheel", "setuptools_scm>=6.2", "grpcio", "grpcio-tools>=1.47.0", "mypy-protobuf==3.1", "sphinx!=4.0.0"]
+requires = [
+  "grpcio-tools>=1.56.2,<2",
+  "grpcio>=1.56.2,<2",
+  "mypy-protobuf==3.1",
+  "protobuf==4.25.4",
+  "pybindgen==0.22.0",
+  "setuptools>=60",
+  "setuptools_scm>=6.2",
+  "sphinx!=4.0.0",
+  "wheel",
+]
 build-backend = "setuptools.build_meta"
 
 [tool.setuptools_scm]
@@ -26,4 +36,4 @@ exclude = [
   "pb2.py",
   ".pyi",
   "protos",
-  "sdk/python/feast/embedded_go/lib"]
+  "sdk/python/feast/embedded_go/lib"]

setup.py

@@ -498,11 +498,12 @@ def run(self):
     entry_points={"console_scripts": ["feast=feast.cli:cli"]},
     use_scm_version=use_scm_version,
     setup_requires=[
-        "setuptools_scm",
-        "grpcio>=1.56.2,<2",
         "grpcio-tools>=1.56.2,<2",
-        "mypy-protobuf>=3.1",
+        "grpcio>=1.56.2,<2",
+        "mypy-protobuf==3.1",
+        "protobuf==4.25.4",
         "pybindgen==0.22.0",
+        "setuptools_scm>=6.2",
     ],
     cmdclass={
         "build_python_protos": BuildPythonProtosCommand,