-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add transformations server endpoint to feature_store.yaml #85
Changes from all commits
8b0bfae
313cb92
084ee0b
3391553
f2d7654
348180d
80857ee
e077c60
aa1e2a1
6bafad7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -177,6 +177,14 @@ class RepoConfig(FeastBaseModel): | |
go_feature_retrieval: Optional[bool] = False | ||
""" If True, use the embedded Go code to retrieve features instead of the Python SDK. """ | ||
|
||
go_transformations_server: Optional[bool] = True | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Had a look at the repo_config. Noticed feature_server section in repo_config. We should have grouped these configs there instead of separate configs. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are adding expedia provider. With that we can always force the flag to TRUE irrespective of what is set in feature_store.yaml. So we can ignore the above comment "Earlier logic was handling: Flag=False and Endpoint=Value, Its using Transformation service. Now it's using GOPY bindings" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about moving configurations to feature_server section? |
||
""" If True, use the transformations server to perform ODVF transformations in Go feature server. """ | ||
|
||
go_transformations_endpoint: Optional[StrictStr] = "" | ||
""" Specify the endpoint for Go feature server to find the transformations server. | ||
NOTE: Unless go_transformations_server is False, the Go feature server will throw errors if this is | ||
blank or null. """ | ||
|
||
entity_key_serialization_version: StrictInt = 1 | ||
""" Entity key serialization version: This version is used to control what serialization scheme is | ||
used when writing data to the online store. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier logic was handling: Flag=False and Endpoint=Value, Its using Transformation service. Now it's using GOPY bindings. Was that the intention when the code was written previously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this version of the code is what should be done. If flag=false, we should be using GOPY bindings. Flag should control whether we use the transformations server or not.