address comments

ExpediaGroup · Apr 2, 2024 · d83f516 · d83f516
1 parent a6ae38a
commit d83f516
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 63 deletions.
diff --git a/dist/431.index.js b/dist/431.index.js
diff --git a/dist/431.index.js.map b/dist/431.index.js.map
diff --git a/dist/676.index.js b/dist/676.index.js
diff --git a/dist/676.index.js.map b/dist/676.index.js.map
diff --git a/src/helpers/approvals-satisfied.ts b/src/helpers/approvals-satisfied.ts
@@ -87,26 +87,20 @@ const fetchTeamLogins = async (team: string) => {
   return data.map(({ login }) => login);
 };
 const updateTeamsList = (teamsList?: string[]) => {
-  if (teamsList) {
-    return teamsList.map(team => {
-      if (!team.includes('/')) {
-        return `${context.repo.owner}/${team}`;
-      } else {
-        return team;
-      }
-    });
-  } else {
-    return undefined;
-  }
+  return teamsList?.map(team => {
+    if (!team.includes('/')) {
+      return `${context.repo.owner}/${team}`;
+    } else {
+      return team;
+    }
+  });
 };
 
 const validateTeamsList = (teamsList?: string[]) => {
-  if (teamsList) {
-    return teamsList.every(team => {
+  return (
+    teamsList?.every(team => {
       const inputOrg = team.split('/')[0];
       return inputOrg === context.repo.owner;
-    });
-  } else {
-    return true;
-  }
+    }) ?? true
+  );
 };