Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manage-merge-queue): remove PRs from queue properly #634

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix(manage-merge-queue): remove PRs from queue properly #634

merged 1 commit into from
Jul 10, 2024

Conversation

danadajian
Copy link
Contributor

📝 Description

  • When a PR is removed from the merge queue, READY FOR MERGE label should be removed even if the PR does not have a "queued for merge" label

@danadajian danadajian requested a review from a team as a code owner July 10, 2024 14:36
eniko
eniko approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@eniko eniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Closing #633 as the fix is done in the manage-merge-queue.

@eniko eniko mentioned this pull request Jul 10, 2024
Closed
@danadajian danadajian merged commit 3483bf7 into main Jul 10, 2024
7 checks passed
@danadajian danadajian deleted the fix-remove-pr-from-queue branch July 10, 2024 14:55
@danadajian
Copy link
Contributor Author

🎉 This PR is included in version 1.57.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eniko eniko eniko approved these changes

Assignees

@PoojaDonekal1294 PoojaDonekal1294

Labels
PEER APPROVED released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danadajian @eniko @PoojaDonekal1294