Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1965: make FunctionDataFetcher handle blocking scopes resulting in a thrown Error as expected #1966

Closed
wants to merge 2 commits into from
Closed

1965: make FunctionDataFetcher handle blocking scopes resulting in a thrown Error as expected #1966

wants to merge 2 commits into from

Commits on Apr 22, 2024

  1. 1965: adjust FunctionDataFetcher to wrap all results in `Completeab… 

    …leFuture`

This makes the result where `runBlockingFunction` ends in a thrown `Error` (or descendant of `Error`) be handled as expected.

Also for consistency makes `runBlockingFunction` wrap the result in a `CompletableFuture` even for the successful case.

Lastly improves grammar a bit adding some commas where needed.
    @wallind
    wallind committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    cca89f8 View commit details
    Browse the repository at this point in the history

  2. 1965: update FunctionDataFetcherTest to work with changes to always… 

    … return `CompletableFuture`
    @wallind
    wallind committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    eeec25b View commit details
    Browse the repository at this point in the history