feat(batching): remove execution if a given operation completes with an exception #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 11, 2024
tapaderster
approved these changes
Jul 11, 2024
samuelAndalon
added a commit
that referenced
this pull request
Jul 11, 2024
…th an exception (#2007) ### 📝 Description #2006 Co-authored-by: Samuel Vazquez <[email protected]>
samuelAndalon
added a commit
that referenced
this pull request
Jul 11, 2024
…th an exception (#2008) ### 📝 Description #2006 Co-authored-by: Samuel Vazquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Example: a persisted query is found, but operationName in the http request is not in the persisted document, causing an unknown operation exception (UnknownOperationException).
Exceptions are converted into graphQL errors at later point, initially thought those errors from exceptions would be in the execution result.