chore: bump eslint-plugin-unicorn to 50.0.1 and fix lint issues

ExpediaGroup · Jan 8, 2024 · fbdd25b · fbdd25b
1 parent 4d1a009
commit fbdd25b
Show file tree

Hide file tree

Showing 61 changed files with 561 additions and 351 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -36,7 +36,7 @@
     "eslint-import-resolver-typescript": "3.6.1",
     "eslint-plugin-import": "2.29.1",
     "eslint-plugin-prettier": "5.1.2",
-    "eslint-plugin-unicorn": "43.0.2",
+    "eslint-plugin-unicorn": "50.0.1",
     "fs-extra": "11.2.0",
     "globby": "11.0.4",
     "graphql": "15.8.0",

diff --git a/packages/backend/src/controllers/webhook.v1.ts b/packages/backend/src/controllers/webhook.v1.ts
@@ -58,15 +58,15 @@ export const hook = (req: Request, res: Response): void => {
   let insightSyncTask: InsightSyncTask | null = null;
   if (req.headers['x-github-event'] !== undefined) {
     insightSyncTask = handleGitHub(webhook);
-  } else if (webhook.path !== undefined) {
+  } else if (webhook.path === undefined) {
+    res.status(400).send('Not Recognized');
+    return;
+  } else {
     insightSyncTask = {
       repositoryType: RepositoryType.FILE,
       owner: 'local',
       repo: webhook.path
     };
-  } else {
-    res.status(400).send('Not Recognized');
-    return;
   }
 
   if (insightSyncTask == null) {