fix(chart)!: Remove namespace and rename image name field (#13)

* renaming repository field in values.yaml * making overwhelm-system namespace opt outable * fixing formatting for values * yaml formatting * addressing comments * increasing chart version * Update .charts/overwhelm/templates/overwhelm-system-namespace.yaml Co-authored-by: TwiN <[email protected]> * addressing comments * reverting version since change shouldn't be breaking by default * removing namespace template, bumping major version due to breaking change Co-authored-by: bora <[email protected]> Co-authored-by: TwiN <[email protected]>
ExpediaGroup · Aug 17, 2022 · 31fd56f · 31fd56f
1 parent af6f3ff
commit 31fd56f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 13 deletions.
diff --git a/.charts/overwhelm/Chart.yaml b/.charts/overwhelm/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: overwhelm
-version: 0.0.3
+version: 1.0.0
 maintainers:
     - name: "Expedia Group"
       url: "https://github.com/ExpediaGroup/overwhelm"
diff --git a/.charts/overwhelm/templates/overwhelm-controller-manager-deployment.yaml b/.charts/overwhelm/templates/overwhelm-controller-manager-deployment.yaml
@@ -24,7 +24,7 @@ spec:
         - --leader-elect
         command:
         - /manager
-        image: {{ .Values.overwhelm.deployment.image.manager.name }}:{{ .Values.overwhelm.deployment.image.manager.tag }}
+        image: {{ .Values.overwhelm.deployment.image.manager.repository }}:{{ .Values.overwhelm.deployment.image.manager.tag }}
         livenessProbe:
           httpGet:
             path: /healthz
@@ -47,7 +47,7 @@ spec:
         - --upstream=http://127.0.0.1:8080/
         - --logtostderr=true
         - --v=0
-        image: {{ .Values.overwhelm.deployment.image.kubeRbacProxy.name }}:{{ .Values.overwhelm.deployment.image.kubeRbacProxy.tag }}
+        image: {{ .Values.overwhelm.deployment.image.kubeRbacProxy.repository }}:{{ .Values.overwhelm.deployment.image.kubeRbacProxy.tag }}
         name: kube-rbac-proxy
         ports:
         - containerPort: 8443

diff --git a/.charts/overwhelm/templates/overwhelm-system-namespace.yaml b/.charts/overwhelm/templates/overwhelm-system-namespace.yaml
diff --git a/.charts/overwhelm/values.yaml b/.charts/overwhelm/values.yaml
@@ -3,10 +3,10 @@ overwhelm:
   deployment:
     image:
       manager:
-        name: ghcr.io/expediagroup/overwhelm
+        repository: ghcr.io/expediagroup/overwhelm
         tag: latest
       kubeRbacProxy:
-        name: gcr.io/kubebuilder/kube-rbac-proxy
+        repository: gcr.io/kubebuilder/kube-rbac-proxy
         tag: v0.8.0
     labels:
       control-plane: controller-manager

diff --git a/config/helm-manifest/manager_deployment_patch.yaml b/config/helm-manifest/manager_deployment_patch.yaml
@@ -14,6 +14,6 @@ spec:
     spec:
       containers:
       - name: manager
-        image: <GOTEMPLATE> .Values.overwhelm.deployment.image.manager.name </GOTEMPLATE>:<GOTEMPLATE> .Values.overwhelm.deployment.image.manager.tag </GOTEMPLATE>
+        image: <GOTEMPLATE> .Values.overwhelm.deployment.image.manager.repository </GOTEMPLATE>:<GOTEMPLATE> .Values.overwhelm.deployment.image.manager.tag </GOTEMPLATE>
       - name: kube-rbac-proxy
-        image: <GOTEMPLATE> .Values.overwhelm.deployment.image.kubeRbacProxy.name </GOTEMPLATE>:<GOTEMPLATE> .Values.overwhelm.deployment.image.kubeRbacProxy.tag </GOTEMPLATE>
+        image: <GOTEMPLATE> .Values.overwhelm.deployment.image.kubeRbacProxy.repository </GOTEMPLATE>:<GOTEMPLATE> .Values.overwhelm.deployment.image.kubeRbacProxy.tag </GOTEMPLATE>