Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to helm upgrade #47

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Adapt to helm upgrade #47

merged 5 commits into from
Feb 9, 2024

Conversation

sangdammad
Copy link
Contributor

📝 Description

  • Added all helm statuses when status is in progress. Only ignore reconciling statuses as they are intermediate statuses that are not adding any value

🔗 Related Issues

manali1205
manali1205 reviewed Feb 8, 2024
View reviewed changes
controllers/application_controller_test.go Outdated
if len(app.Status.Conditions) != 2 {
fmt.Println(app.Status.Conditions[0].Message)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be removed now?

@manali1205
Copy link

And no need to update chart version I suppose?

@sangdammad sangdammad merged commit 415a44c into master Feb 9, 2024
1 check passed
@sangdammad sangdammad deleted the adapt_to_helm_upgrade branch February 9, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manali1205 manali1205 manali1205 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sangdammad @manali1205