Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the db prefix not being removed from request parameters in method refresh_privileges #312

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

flaming-archer
Copy link
Contributor

📝 Description

Fix the db prefix not being removed from request parameters.
This issue will cause the log to keep reporting errors.

16:32:57.906 [pool-6-thread-73] INFO com.hotels.bdp.waggledance.client.compatibility.HiveCompatibleThriftHiveMetastoreIfaceFactory - Couldn't invoke method public abstract org.apache.hadoop.hive.metastore.api.GrantRevokePrivilegeResponse org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Iface.refresh_privileges(org.apache.hadoop.hive.metastore.api.HiveObjectRef,java.lang.String,org.apache.hadoop.hive.metastore.api.GrantRevokePrivilegeRequest) throws org.apache.hadoop.hive.metastore.api.MetaException,org.apache.thrift.TException

🔗 Related Issues

@flaming-archer flaming-archer changed the title fix refresh_privileges Fix the db prefix not being removed from request parameters Apr 10, 2024
@flaming-archer flaming-archer changed the title Fix the db prefix not being removed from request parameters Fix the db prefix not being removed from request parameters in method refresh_privileges Apr 10, 2024
@flaming-archer
Copy link
Contributor Author

This failed test case get_table_meta seems to have been consistently slow and prone to timeout. It shouldn't have been affected by my changes

@patduin patduin merged commit 61dd787 into ExpediaGroup:hive-3.x Apr 11, 2024
2 of 3 checks passed
@patduin
Copy link
Contributor

patduin commented Apr 11, 2024

Thank you @flaming-archer!

flaming-archer added a commit to flaming-archer/waggle-dance that referenced this pull request Apr 12, 2024
… refresh_privileges (ExpediaGroup#312)

* fix refresh_privileges

* add unit test and use old function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants