Added metrics and removed retryHandler #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javsanbel2
reviewed
Oct 2, 2024
javsanbel2
reviewed
Oct 2, 2024
| @Component | ||
| public class TTransportMonitor { | ||
|
|
||
| static final String METRIC_NAME_OPEN_TRANSPORTS = "open_transports_gauge"; |
There was a problem hiding this comment.
In this class you have a metric base name - (https://github.com/ExpediaGroup/waggle-dance/blob/main/waggle-dance-extensions/src/main/java/com/hotels/bdp/waggledance/extensions/client/ratelimit/RateLimitMetrics.java#L24)
Are you gonna add a base metric name also here to align with all metrics?
There was a problem hiding this comment.
yeah I should I was testing out how it looks with the prefix, but I'll add a namespace
javsanbel2
reviewed
Oct 2, 2024
javsanbel2
approved these changes
Oct 2, 2024
mollonado
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Related Issues