Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Standardize the Pay Button] Add support for new NVP shape private_lastPaymentMethod in App #55873

Open
grgia opened this issue Jan 28, 2025 · 4 comments
Assignees
Labels
Reviewing Has a PR in review Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Jan 28, 2025

Design Doc

Goal

Users with the old NVP shape will not run into issues when code references the new NVP shape.

Update all existing references in the app to check if private_lastPaymentMethod. is a string or an object to maintain backward compatibility for users with the old structure.

App should work regardless of which NVP shape the user has.

Context:

The previous private_lastPaymentMethod structure was:

private_lastPaymentMethod: {
   <policyID>: <preference>,
}

The updated structure in private_lastPaymentMethod will look like:

private_lastPaymentMethod: {
   <policyID>: {
		lastUsed: <preference>,
		Iou: <preference>,
		Expense: <preference>,
		Invoice: <preference>,
    }
}
@grgia grgia added the Daily KSv2 label Jan 28, 2025
@grgia grgia changed the title [Standardize the Pay Button] Update how we use the NVP private_lastPaymentMethod in App [HOLD E/E #465082] [Standardize the Pay Button] Update how we use the NVP private_lastPaymentMethod in App Jan 28, 2025
@grgia grgia changed the title [HOLD E/E #465082] [Standardize the Pay Button] Update how we use the NVP private_lastPaymentMethod in App [Standardize the Pay Button] Update how we use the NVP private_lastPaymentMethod in App Jan 28, 2025
@grgia grgia changed the title [Standardize the Pay Button] Update how we use the NVP private_lastPaymentMethod in App [Standardize the Pay Button] Add support for new NVP shape private_lastPaymentMethod in App Jan 28, 2025
@grgia grgia added Hot Pick Ready for an engineer to pick up and run with and removed Hot Pick Ready for an engineer to pick up and run with labels Jan 28, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 31, 2025
@grgia
Copy link
Contributor Author

grgia commented Jan 31, 2025

@hungvu193 @getusha do you have enough context to take this one for App?

@melvin-bot melvin-bot bot removed the Overdue label Jan 31, 2025
@getusha
Copy link
Contributor

getusha commented Jan 31, 2025

Yes, i think it's quite straightforward. I'll handle this one.

@hungvu193
Copy link
Contributor

Draft PR is here: #56210

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 2, 2025
@hungvu193
Copy link
Contributor

#56210 is ready for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants