Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] feat: add unit tests for edit money request and payment via vbba #27609

Merged
merged 11 commits into from
Oct 23, 2023
Merged

[No QA] feat: add unit tests for edit money request and payment via vbba #27609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5d51206
feat: add unit tests for edit money request and payment via vbba
allroundexperts Sep 16, 2023
e26835f
fix: lint errors
allroundexperts Sep 16, 2023
7075af7
feat: merge with main
allroundexperts Oct 8, 2023
1bb71f6
feat: resolve conflicts
allroundexperts Oct 8, 2023
c1701ee
fix: lint issues
allroundexperts Oct 8, 2023
3b04dfd
fix: handle comment suggestions
allroundexperts Oct 8, 2023
b9d1a0a
fix: lint issues
allroundexperts Oct 8, 2023
64c1053
fix: more lint issues
allroundexperts Oct 8, 2023
83fcaaa
Merge branch 'main' into fix-26366
allroundexperts Oct 22, 2023
9c2df99
fix: remove duplicated policy utils import
allroundexperts Oct 22, 2023
c54734a
fix: handle comment suggestions
allroundexperts Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/libs/actions/IOU.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1894,17 +1894,17 @@ function editMoneyRequest(transactionID, transactionThreadReportID, transactionC
},
},
{
onyxMethod: Onyx.METHOD.MERGE,
onyxMethod: Onyx.METHOD.SET,
key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`,
value: transaction,
},
{
onyxMethod: Onyx.METHOD.MERGE,
onyxMethod: Onyx.METHOD.SET,
key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport.reportID}`,
value: iouReport,
},
{
onyxMethod: Onyx.METHOD.MERGE,
onyxMethod: Onyx.METHOD.SET,
key: `${ONYXKEYS.COLLECTION.REPORT}${iouReport.chatReportID}`,
value: chatReport,
},
Comment on lines -1897 to 1910
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure this is the best practice, but from this it seems fine to me to use SET

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MERGE merges both previous and the new data. In this case however, we're generating new optimistic objects for transaction, iouReport and chatReport. As such, it makes sense to use SET directly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change caused regression.

Issue -> "IOU - Edited amount for a paid request does not revert to initial amount after closing error message"

Expand Down
Loading
Loading