[No QA] Console error cleanup pt3

[kubabutkiewicz]

Explanation of Change

Fixed console errors in that issue:

• Native - Attachment view `None of the callback in the gesture are worklets. If you wish to run them on the JS thread use '.runOnJS(true)' modifier on the gesture to make this explicit. Otherwise, mark the callback as 'worklet' to run them on the UI thread.
• MoneyRequestConfirmationListFooter - Each child in a list should have a unique 'key' prop
• TextBlock - Each child in a list should have a unique 'key' prop
• Web - validateDOMNesting(...): <button> cannot appear as a descendant of <button>.
• SearchRouter - Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?
• Submit expense flow - ref.measureLayout need to be called with native component

Fixed Issues

$ #55045
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[dukenv0307]

@kubabutkiewicz How to reproduce these console errors?

URL - Error parsing URL: TypeError: Failed to construct 'URL': Invalid URL

Native - Attachment view `None of the callback in the gesture are worklets. If you wish to run them on the JS thread use '.runOnJS(true)' modifier on the gesture to make this explicit. Otherwise, mark the callback as 'worklet' to run them on the UI thread.

[dukenv0307]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

• Native - Attachment view

Screen.Recording.2025-02-03.at.23.22.30.mov

• Submit expense flow - ref.measureLayout need to be called with native component

Screen.Recording.2025-02-07.at.22.59.57.mov

• split expense: Each child in a list should have a unique 'key' prop

Screen.Recording.2025-02-07.at.23.00.40.mov

Android: mWeb Chrome

iOS: Native

• Native - Attachment view

Screen.Recording.2025-02-03.at.23.16.34.mov

• Submit expense flow - ref.measureLayout need to be called with native component

Screen.Recording.2025-02-07.at.22.46.10.mov

• split expense: Each child in a list should have a unique 'key' prop

Screen.Recording.2025-02-07.at.22.50.04.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Before

• MoneyRequestConfirmationListFooter - Each child in a list should have a unique 'key' prop

• TextBlock - Each child in a list should have a unique 'key' prop

• Web - validateDOMNesting(...): cannot appear as a descendant of .

• SearchRouter - Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

After

• MoneyRequestConfirmationListFooter - Each child in a list should have a unique 'key' prop

TextBlock - Each child in a list should have a unique 'key' prop

SearchRouter - Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

web-resize.mp4

• Web - validateDOMNesting(...): cannot appear as a descendant of .

MacOS: Desktop

web-resize.mp4

[dukenv0307]

@kubabutkiewicz Can you please add the screenshot/video?

This issue is not fixed

Web - validateDOMNesting(...): cannot appear as a descendant of .

[dukenv0307]

I just can reproduce 4 of 6 console errors mentioned here.

2 errors I can't reproduce

And 1 error is failed

[kubabutkiewicz]

@dukenv0307

URL - Error parsing URL: TypeError: Failed to construct 'URL': Invalid URL

Was happening when I was entering channel called #admins on any workspace

Native - Attachment view `None of the callback in the gesture are worklets. If you wish to run them on the JS thread use '.runOnJS(true)' modifier on the gesture to make this explicit. Otherwise, mark the callback as 'worklet' to run them on the UI thread.

Was happening when opening attachments on native

I will take a look at the failed error

[dukenv0307]

Was happening when I was entering channel called #admins on any workspace

I still can't reproduce, can you share the steps on latest main

Was happening when opening attachments on native

I just see the following warn/error

not sure it's what we're trying to fix

[kubabutkiewicz]

@dukenv0307 For me the URL - Error parsing URL: TypeError: Failed to construct 'URL': Invalid URL error is happening only for one of my accounts.

about issue with react-native-gesture-handler we want to just get rid of those errors which are on the screenshot you posted.
This is what is happening on the main when I am opening uploaded attachment

And this is from my branch

I also added the fix for failed error

[kubabutkiewicz]

I pushed change @dukenv0307 but I was asked if I can include one more fix #55045 (comment) which I need some time to fix so its not ready to review

[dukenv0307]

@kubabutkiewicz Thank you. BTW, can you please add the detail on the PR description about what we fixed, it helps QA easily to follow

[kubabutkiewicz]

Verify HybridApp build/ Comment on all PRs that are forks step is failing but I think its not a problem with this PR. I see there is another PR trying to fix this workflow #56417.
Beside that @dukenv0307 its ready to review. I added all errors fixed in the description

[dukenv0307]

Can you explain about this change?

[kubabutkiewicz]

This is basically taken from react-native codebase https://github.com/facebook/react-native/blob/fffd6d75b48ae1f6c78dbc0f7e9b6fe509df3394/packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/ReactFabricHostComponent.js#L91-L99 no not call this method without proper type.

[dukenv0307]

Code looks good and tests well. I just left 1 minor question. And can you please mark this task as done?

Submit expense flow - ref.measureLayout need to be called with native component

[dukenv0307]

@kubabutkiewicz any updates?

[kubabutkiewicz]

Sorry missed your comment, answered.

[dukenv0307]

@kubabutkiewicz Can you please merge main, I think the failing test is fixed

[kubabutkiewicz]

@dukenv0307 done but I think the workflow isnt fixed yet, PR which I mentioned earlier isnt merged yet

[dukenv0307]

@kubabutkiewicz That's weird, I don't see any problems on some recent PRs. For example: #56678

[kubabutkiewicz]

@mountiny can you help with checking why the VerifyHybridApp is failing?

[kubabutkiewicz]

@dukenv0307 I think I know what an issue, this workflow is only running when we are changing one of the files on this paths

      - '**.kt'
      - '**.java'
      - '**.swift'
      - '**.mm'
      - '**.h'
      - '**.cpp'
      - 'package.json'
      - 'patches/**'
      - 'android/build.gradle'
      - 'android/AndroidManifest.xml'
      - 'ios/Podfile.lock'
      - 'ios/project.pbxproj'

but the workflow is broken thats why its failing

[dukenv0307]

@kubabutkiewicz Agree, I think this PR should be merged

[dukenv0307]

LGTM

[melvin-bot]

We did not find an internal engineer to review this PR, trying to assign a random engineer to #55045 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

[github-actions]

🚧 @lakchote has triggered a test build. You can view the workflow run here.

[github-actions]

🚧 @lakchote has triggered a test hybrid app build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55066/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/55066/index.html
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

---

👀 View the workflow run that generated this build 👀