Reset request flow when logout #55384

cretadn22 · 2025-01-17T04:00:33Z

Explanation of Change

Fixed Issues

$ #54432
PROPOSAL: #54432 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Precondition: Your default currency should not be USD when you create expense

Click on plus icon and click on Submit expense
Enter any amount and continue, select any user and continue
Copy the URL, link should look like: https://staging.new.expensify.com/request/new/confirmation/
Logout and paste the URL in browser
Login
App should display a new money request flow

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-11.at.19.46.00.mov

Android: mWeb Chrome

20.mp4

iOS: Native

Screen.Recording.2025-02-11.at.19.46.24.mov

iOS: mWeb Safari

19.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-01-17.at.10.55.11.mp4

MacOS: Desktop

Screen.Recording.2025-02-11.at.19.44.44.mov

melvin-bot · 2025-01-17T04:00:38Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cretadn22 · 2025-01-24T16:02:20Z

@ishpaul777 ✋

ishpaul777 · 2025-01-24T19:15:04Z

Thanks for the bump! will review over weekend

ishpaul777 · 2025-01-24T19:15:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-11.at.2.17.04.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-02-11.at.1.14.23.AM.mov

iOS: Native

Screen.Recording.2025-02-11.at.1.14.23.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-02-07.at.3.09.53.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-02-07.at.2.50.33.AM.mov

Screen.Recording.2025-02-07.at.2.51.17.AM.mov

MacOS: Desktop

Screen.Recording.2025-02-11.at.2.21.29.AM-1.mov

ishpaul777 · 2025-01-26T20:01:26Z

it seems to be not fixed @cretadn22

Screen.Recording.2025-01-27.at.1.28.28.AM.mov

also when I try to track a expense it redirects me back to amount page

Screen.Recording.2025-01-27.at.1.34.02.AM.mov

cretadn22 · 2025-01-27T18:55:09Z

@ishpaul777 Your steps differ from the step of this PR. We only reset the money request flow when the user logs out. In your case, since you didn’t log out, the transaction draft still remains

ishpaul777 · 2025-01-28T21:55:25Z

@cretadn22 i think even then this is still a bug, no?

also when I try to track a expense it redirects me back to amount page

cretadn22 · 2025-01-30T07:29:39Z

@ishpaul777 It looks like you're following a different set of test steps than the ones mentioned in the PR description. Could you clarify the steps you're using and what the expected behavior should be?

ishpaul777 · 2025-02-02T19:29:26Z

also when I try to track a expense it redirects me back to amount page

i tried to reproduce this issue after merging main locally and its not reproducible, I'll continue testing and review, meanwhile please merge main

cretadn22 · 2025-02-03T10:43:58Z

@ishpaul777 Merged main

ishpaul777 · 2025-02-05T20:10:27Z

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

+        if (transaction?.transactionID) {
+            return;
+        }


can we make it such that even if transaction.transactionID exists we check if the basic transaction properties exists, other wise if user again go back `create/submit/confirmation/1/ second time he'll see this which is not so relevant and its exactly what we want to fix

@ishpaul777 Could you please clarify your issue? How are you reproducing it, and what is the expected outcome? It seems like you're following a different test process, but you haven’t specified that, making it difficult for me to reproduce the issue. This is causing delays in completing this PR.

Same as test steps in Pr description, once you got redirected to start of flow close it, and paste the copied url again it will link to empty confirmation page

@ishpaul777 Fixed

still not fixed on ios/android, here I deeplink to create/submit/confirmation/1/<Reportid> it don't not redirect me to start of flow

Screen.Recording.2025-02-07.at.3.25.01.AM.mov

@ishpaul777 I can't reproduce that on IOS

Screen.Recording.2025-02-07.at.20.54.15.mov

i can still reproduce this issue same steps as in my initial comment

@ishpaul777 Could you try again using a new account and record your screen, including all the steps?

I just tried many time but still can't reproduce your bug

i could not reproduce this anymore

ishpaul777 · 2025-02-07T18:10:10Z

i still seem to have other issue like on IOS when I try to submit expense and select participant I am moved back to starting step. this is reproducable consistently now

Screen.Recording.2025-02-07.at.11.36.48.PM.mov

@cretadn22

cretadn22 · 2025-02-09T05:02:15Z

This bug is fixed

ishpaul777 · 2025-02-10T20:55:51Z

@cretadn22 Please complete all platform demo video its still pending for some in author checklist

Beamanator · 2025-02-11T01:14:15Z

Ooh yeah please upload the missing videos @cretadn22 🙏

cretadn22 · 2025-02-11T12:49:43Z

@ishpaul777 @Beamanator Sorry, I didn't upload videos on mobile platforms because this bug can't reproduce on these platforms. I updated the video by using deep link on mobile and desktop

Beamanator · 2025-02-11T20:06:03Z

@cretadn22 that's understandable why you'd do that, but we still want to take care to make sure the native apps work from absolutely any change, so in the future please test all platforms no matter what 🙏

github-actions · 2025-02-12T02:07:15Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.0.97-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-12T22:06:45Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.97-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

reset request flow

c8ed1eb

cretadn22 requested a review from a team as a code owner January 17, 2025 04:00

melvin-bot bot requested review from ishpaul777 and removed request for a team January 17, 2025 04:00

cretadn22 added 3 commits January 17, 2025 22:07

update new lint rule

790d041

new main

e2e1562

adjust style

a7ff340

cretadn22 force-pushed the reset-request-flow branch from 8586492 to a7ff340 Compare January 17, 2025 15:35

prettier

263d291

main new

b9c08b8

new latest main

a4d4b87

new main

cd982a4

ishpaul777 reviewed Feb 5, 2025

View reviewed changes

fix one more case

4a7138e

cretadn22 added 2 commits February 9, 2025 11:37

new main

84659e1

add isLoadingTransaction condition

768a833

ishpaul777 approved these changes Feb 10, 2025

View reviewed changes

melvin-bot bot requested a review from Beamanator February 10, 2025 20:54

Beamanator approved these changes Feb 11, 2025

View reviewed changes

Beamanator merged commit 3eb6bf1 into Expensify:main Feb 11, 2025
18 of 20 checks passed

github-actions bot mentioned this pull request Feb 12, 2025

Deploy Checklist: New Expensify 2025-02-12 #56710

Closed

33 tasks

IuliiaHerets mentioned this pull request Feb 12, 2025

Create Expense - Deeplinking expense creation leads to an expense with 0 amount #56752

Open

8 tasks

melvin-bot bot mentioned this pull request Feb 12, 2025

[Due for payment 2025-02-19] [$250] Create expense - Request confirmation link changes expense currency to USD #54432

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reset request flow when logout #55384

Reset request flow when logout #55384

cretadn22 commented Jan 17, 2025 •

edited

Loading

melvin-bot bot commented Jan 17, 2025

cretadn22 commented Jan 24, 2025

ishpaul777 commented Jan 24, 2025

ishpaul777 commented Jan 24, 2025 •

edited

Loading

ishpaul777 commented Jan 26, 2025 •

edited

Loading

cretadn22 commented Jan 27, 2025

ishpaul777 commented Jan 28, 2025

cretadn22 commented Jan 30, 2025

ishpaul777 commented Feb 2, 2025

cretadn22 commented Feb 3, 2025

ishpaul777 Feb 5, 2025

cretadn22 Feb 6, 2025

ishpaul777 Feb 6, 2025

cretadn22 Feb 6, 2025

ishpaul777 Feb 6, 2025

cretadn22 Feb 7, 2025

ishpaul777 Feb 7, 2025

cretadn22 Feb 9, 2025

cretadn22 Feb 9, 2025

ishpaul777 Feb 10, 2025

ishpaul777 commented Feb 7, 2025 •

edited

Loading

cretadn22 commented Feb 9, 2025

ishpaul777 commented Feb 10, 2025

Beamanator commented Feb 11, 2025

cretadn22 commented Feb 11, 2025

Beamanator commented Feb 11, 2025

github-actions bot commented Feb 12, 2025

github-actions bot commented Feb 12, 2025

Reset request flow when logout #55384

Reset request flow when logout #55384

Conversation

cretadn22 commented Jan 17, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 17, 2025

cretadn22 commented Jan 24, 2025

ishpaul777 commented Jan 24, 2025

ishpaul777 commented Jan 24, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Jan 26, 2025 • edited Loading

cretadn22 commented Jan 27, 2025

ishpaul777 commented Jan 28, 2025

cretadn22 commented Jan 30, 2025

ishpaul777 commented Feb 2, 2025

cretadn22 commented Feb 3, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishpaul777 commented Feb 7, 2025 • edited Loading

cretadn22 commented Feb 9, 2025

ishpaul777 commented Feb 10, 2025

Beamanator commented Feb 11, 2025

cretadn22 commented Feb 11, 2025

Beamanator commented Feb 11, 2025

github-actions bot commented Feb 12, 2025

github-actions bot commented Feb 12, 2025

cretadn22 commented Jan 17, 2025 •

edited

Loading

ishpaul777 commented Jan 24, 2025 •

edited

Loading

ishpaul777 commented Jan 26, 2025 •

edited

Loading

ishpaul777 commented Feb 7, 2025 •

edited

Loading