[HybridApp] Add HybridApp turbomodule #57406
Conversation
# Conflicts: # Mobile-Expensify # package-lock.json # src/libs/Environment/getEnvironment/index.native.ts # src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx
|
|
|
|
|
|
|
|
|
|
||
| // eslint-disable-next-line rulesdir/no-inline-named-export, @typescript-eslint/consistent-type-definitions | ||
| export interface Spec extends TurboModule { | ||
| isHybridApp: () => boolean; |
There was a problem hiding this comment.
I would even store this value somewhere in order not to do a call to native code each time it is checked. It won't change during the lifetime of app so it should be safe I guess.
| "type": "modules", | ||
| "jsSrcsDir": "src" | ||
| }, | ||
| "author": " <> ()", |
There was a problem hiding this comment.
Maybe we want to fill those fields too?
| @@ -0,0 +1,3 @@ | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
Why are those manifests needed?
| if (isNewArchitectureEnabled()) { | ||
| react { | ||
| jsRootDir = file("../src/") | ||
| libraryName = "ReactNativeHybridApp" | ||
| codegenJavaPackageName = "com.expensify.reactnativehybridapp" | ||
| } | ||
| } |
There was a problem hiding this comment.
| if (isNewArchitectureEnabled()) { | |
| react { | |
| jsRootDir = file("../src/") | |
| libraryName = "ReactNativeHybridApp" | |
| codegenJavaPackageName = "com.expensify.reactnativehybridapp" | |
| } | |
| } |
These lines are not needed
|
|
||
| sourceSets { | ||
| main { | ||
| if (isNewArchitectureEnabled()) { |
There was a problem hiding this comment.
We are always having new arch so we could remove it but w/e
| } | ||
|
|
||
| android { | ||
| if (supportsNamespace()) { |
There was a problem hiding this comment.
We know that we have higher version of gradle so we could remove it too.
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop