Support custom parsing logic (pass worklet as parser prop)
#439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
reviewed
Oct 8, 2024
android/src/main/java/com/expensify/livemarkdown/LiveMarkdownModule.java
Outdated
Show resolved
Hide resolved
tomekzaw
commented
Oct 9, 2024
android/src/main/java/com/expensify/livemarkdown/LiveMarkdownModule.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/expensify/livemarkdown/LiveMarkdownModule.java
Outdated
Show resolved
Hide resolved
j-piasecki
reviewed
Oct 31, 2024
| #ifdef RCT_NEW_ARCH_ENABLED | ||
| RCTScheduler *scheduler = [surfacePresenter_ scheduler]; | ||
| commitHook_ = std::make_shared<MarkdownCommitHook>(scheduler.uiManager); | ||
| installed_ = YES; |
There was a problem hiding this comment.
I believe this can be removed (and the property as well)
| auto json = rt.global().getPropertyAsObject(rt, "JSON").getPropertyAsFunction(rt, "stringify").call(rt, result).asString(rt).utf8(rt); | ||
| jni::alias_ref<jni::JString> input, | ||
| int parserId) { | ||
| const auto markdownRuntime = expensify::livemarkdown::getMarkdownRuntime(); |
There was a problem hiding this comment.
Is there any chance to somehow indicate here that this method is synchronized and mutex isn't necessary here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR removes separate JS bundle with ExpensiMark logic and allows for customizing
MarkdownTextInputformatting logic viaparserproperty. Parser needs to be a function that accepts a plaintext string and returns an array of ranges.Related Issues
#317
Manual Tests
Linked PRs