Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix console errors on page reload when the input is empty #509

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix console errors on page reload when the input is empty #509

merged 1 commit into from
Oct 3, 2024

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Oct 2, 2024

Details

Related Issues

Expensify/App#49973

Manual Tests

  1. Set default input value to ""
  2. Click on it
  3. Verify if there are no console errors

Linked PRs

@Skalakid Skalakid mentioned this pull request Oct 2, 2024
Closed
5 tasks
BartoszGrajdek
BartoszGrajdek approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Skalakid Skalakid merged commit 7af4555 into main Oct 3, 2024
5 checks passed
@Skalakid Skalakid deleted the @Skalakid/revert-follow-ups branch October 3, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BartoszGrajdek BartoszGrajdek BartoszGrajdek approved these changes

@tomekzaw tomekzaw Awaiting requested review from tomekzaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skalakid @BartoszGrajdek