Fix scrolling lines into view #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s77rt
suggested changes
Oct 9, 2024
tomekzaw
reviewed
Oct 10, 2024
tomekzaw
approved these changes
Oct 10, 2024
s77rt
reviewed
Oct 10, 2024
| // In case the caret is below the visible input area, scroll to the end of the node | ||
| if (caretRect.top + caretRect.height > targetRect.top + targetRect.height) { | ||
| targetElement.scrollTop = caretRect.top - targetRect.top + target.scrollTop - targetRect.height + caretRect.height + 4; | ||
| return; |
There was a problem hiding this comment.
Yes, we only want to change scrollTop. Executing the rest of the code below can cause scroll jumps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
THis PR fixies the problem with scrolling elements into view.It changes the logic to now scroll the whole line into view instead of just a child element
Related Issues
Expensify/App#50174
Manual Tests
Linked PRs