Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline images flickering #516

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

Skalakid
Copy link
Collaborator

Details

This PR fixes the inline image flickering bug, when removing the line after it

Screen.Recording.2024-10-10.at.11.41.57.mov

Related Issues

Expensify/App#50047

Manual Tests

  1. Open an example app
  2. Add a new line after the image
  3. Hit backspace
  4. Verify if the image didn't flicker

Linked PRs

BartoszGrajdek
BartoszGrajdek previously approved these changes Oct 10, 2024
Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BartoszGrajdek
Copy link
Collaborator

Make sure test web E2E is not failing before merging - I've just run that again

@Skalakid Skalakid force-pushed the @Skalakid/fix-inline-image-flickering branch from 1b1e801 to fb7f691 Compare October 11, 2024 11:54
@Skalakid Skalakid marked this pull request as ready for review October 15, 2024 13:43
@Skalakid Skalakid merged commit e312fb8 into main Oct 16, 2024
5 checks passed
@Skalakid Skalakid deleted the @Skalakid/fix-inline-image-flickering branch October 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants