-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added dominantColor function #255
Open
MarkOtten
wants to merge
15
commits into
EyalAr:master
Choose a base branch
from
MarkOtten:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't it be "dominantColor"? Love the change though, hopefully this lands in a release soon :) |
I was thinking "the color that dominates the picture" when I initially wrote the function, though that could have been the middle of the night lack of sleep more than anything else. I will update it to dominantColor and push it when I get a chance. |
randytarampi
added a commit
to randytarampi/lwip
that referenced
this pull request
Apr 28, 2020
Pull `dominantColor`s per #28 Closes #28 and EyalAr#255
randytarampi
added a commit
to randytarampi/lwip
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dominantColor(arg) returns the color that appears most often in an image, the specified integer argument is the number of pixels to skip per iteration, while iterating through an image.