Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

used response stats as fallback if bundleReport.stats is undefined #341

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

gqcorneby
Copy link

@gqcorneby gqcorneby commented Jan 15, 2025

📌 References

  • Issue: Closes #8696ark8f

📝 Implementation

  • updating response handling for /tracker/jobs/<id>/report/. Use response stats as fallback if bundleReport.stats is undefined.

🔥 Notes for the reviewer

📹 Screenshots/Screen capture

image
image
image
image

📑 Others

@ifoche
Copy link
Member

ifoche commented Jan 15, 2025

Task linked: CU-8696ark8f [Bulk Load] 41 compatibility

@gqcorneby gqcorneby requested review from tokland and adrianq January 15, 2025 10:56
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment about the type.

src/data/Dhis2Import.ts Show resolved Hide resolved
Copy link

@tokland tokland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, all good 👍

src/data/Dhis2Import.ts Show resolved Hide resolved
@adrianq adrianq merged commit 5e9dc26 into development Jan 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants