Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: when delete prod you also delete all connected layouts #40

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

malmen237
Copy link

What does this do?

When deleting a production this pr adds a db-delete to all layouts connected to that production.

@malmen237 malmen237 requested a review from LucasMaupin October 16, 2024 14:57
Copy link

@Saelmala Saelmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor comment about the error message, otherwise it looks good and works as expected

@malmen237 malmen237 changed the base branch from main to feat/delete-from-layout-config October 17, 2024 08:28
@malmen237 malmen237 force-pushed the feat/delete-all-prod-layouts-when-delete-prod branch from d237644 to 97ada5e Compare October 17, 2024 08:43
Base automatically changed from feat/delete-from-layout-config to main October 17, 2024 12:51
@malmen237 malmen237 merged commit a538d29 into main Oct 17, 2024
4 checks passed
@malmen237 malmen237 deleted the feat/delete-all-prod-layouts-when-delete-prod branch October 17, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants