feat: create html and media sources in api #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasMaupin
requested changes
Oct 22, 2024
src/app/api/manager/pipelines/[id]/rendering-engine/media/[input_slot]/route.ts
Outdated
Show resolved
Hide resolved
src/app/api/manager/pipelines/[id]/rendering-engine/media/[input_slot]/route.ts
Outdated
Show resolved
Hide resolved
src/app/api/manager/pipelines/[id]/rendering-engine/media/get/route.ts
Outdated
Show resolved
Hide resolved
LucasMaupin
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Instead of using a WebSocket to create HTML and Media sources, the REST API is used since the functionality is in place now.
When adding a HTML/Media source to a production, the user is able to specify a URL (for HTML) or filename (Media) beforehand which will mean that when the production is started, those will already be loaded in the multiview. It is possible to also leave these blank, and instead load something later using the media load <input_slot> and html load <input_slot> commands.
Modal to add HTML:
Modal to add Media:
