fix/ edit button gets wrapped #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saelmala
reviewed
Oct 29, 2024
There was a problem hiding this comment.
It is possible to add sources to a production even though in locked mode when clicking the card, that should be disabled if locked
Saelmala
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Overall LGTM, however, it should not be possible to add sources to a production when in locked mode
Edit: The problem was only if the inventory list was open before the app was put in locked mode, but since the list is by default closed and only possible to open after unlock, this was not deemed a problem
Saelmala
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Button changed to icon
The button itself is obsolete since the entire source-card is made into a click-area. So removed the button and added an icon to the top corner of the source-card, to guide the user into clicking the card.
A pen-icon instead of "edit" for the inventory-page:
A plus-icon instead of "add" for the production-page:
Some cleanup and minor adjustments