Fix handling of single quotes in shell commands #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a command in the `bigip_command` resource contained single quotes, the constructed shell command would have unbalanced quotes, leading to syntax errors and command execution failures. This commit fixes the issue by escaping single quotes within the commands before wrapping them in single quotes. This ensures that all commands are properly formatted and executed, even if they contain single quotes. - Escape single quotes in commands before constructing the shell command - Prevents syntax errors due to unbalanced quotes - Enhances security by mitigating potential command injection risks
|
Hi @alex-harvey-z3q, In order to review and accept your commit, you need to sign a Customer License Agreement and send it to [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a command in the
bigip_commandresource contained single quotes, the constructed shell command would have unbalanced quotes, leading to syntax errors and command execution failures. This commit fixes the issue by escaping single quotes within the commands before wrapping them in single quotes. This ensures that all commands are properly formatted and executed, even if they contain single quotes.