Skip to content

Commit

Permalink
Merge branch 'release'
Browse files Browse the repository at this point in the history
* release:
  Update documentation release 1.2.4
  CHG: updated changelog
  CHG: removed legacy tracking code
  CHG: added userId parameter to methods
  Update XmlConfiguration.php
  • Loading branch information
tuegeb committed Jul 11, 2016
2 parents 69d4426 + 80613a1 commit fbea6c2
Show file tree
Hide file tree
Showing 171 changed files with 3,009 additions and 3,027 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
Version 1.2.4
- Added userId parameter to TrackingAdapter methods doTrackingFromRequest/setupTrackingFromRequest
- Extended constructor in order to support not only file based XMLConfiguration by @asdfklgash
- Removed legacy tracking code

Version 1.2.3
- Fixed wrong function name called by @ marfis
- Moved methods getError and getStacktrace to AbstractAdapter
Expand Down
36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Adapter.AbstractAdapter.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Adapter.Compare.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Adapter.Import.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Adapter.ProductCampaign.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Adapter.Recommendation.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Adapter.Search.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Adapter.SimilarRecords.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Adapter.Suggest.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Adapter.TagCloud.html

Large diffs are not rendered by default.

94 changes: 52 additions & 42 deletions docs/classes/FACTFinder.Adapter.Tracking.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.AbstractConfiguration.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.AbstractEncodingConverter.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.ArrayConfiguration.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Client.RequestParser.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Client.UrlBuilder.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.ConfigurationInterface.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.IConvEncodingConverter.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.ManualConfiguration.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.ParametersConverter.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.AbstractDataProvider.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.ConnectionData.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.EasyCurlDataProvider.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.EasyCurlRequestFactory.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.FileSystemDataProvider.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.FileSystemRequestFactory.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.MultiCurlDataProvider.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.MultiCurlRequestFactory.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.NullResponse.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.Request.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.RequestFactoryInterface.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.Response.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Server.UrlBuilder.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Core.Utf8EncodingConverter.html

Large diffs are not rendered by default.

43 changes: 24 additions & 19 deletions docs/classes/FACTFinder.Core.XmlConfiguration.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.AdvisorAnswer.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.AdvisorQuestion.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.AfterSearchNavigation.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.ArticleNumberSearchStatus.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.BreadCrumb.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.BreadCrumbTrail.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.BreadCrumbType.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.Campaign.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.CampaignIterator.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.Filter.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.FilterGroup.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.FilterSelectionType.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.FilterStyle.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.FilterType.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.Item.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.Page.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.Paging.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.Record.html

Large diffs are not rendered by default.

97 changes: 19 additions & 78 deletions docs/classes/FACTFinder.Data.Result.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.ResultsPerPageOptions.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.SearchParameters.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.SearchStatus.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.SingleWordSearchItem.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.SliderFilter.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.Sorting.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.SuggestQuery.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Data.TagQuery.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Loader.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Util.Curl.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Util.CurlHandle.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Util.CurlInterface.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Util.CurlMultiHandle.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Util.CurlStub.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Util.Log4PhpLogger.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Util.LoggerInterface.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Util.NullLogger.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Util.Parameters.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/classes/FACTFinder.Util.Pimple.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/files/Adapter.AbstractAdapter.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/files/Adapter.Compare.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/files/Adapter.Import.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/files/Adapter.ProductCampaign.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/files/Adapter.Recommendation.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/files/Adapter.Search.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/files/Adapter.SimilarRecords.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/files/Adapter.Suggest.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/files/Adapter.TagCloud.html

Large diffs are not rendered by default.

36 changes: 18 additions & 18 deletions docs/files/Adapter.Tracking.html

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions docs/files/Adapter/Search.php.txt
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,11 @@ class Search extends AbstractAdapter
//init default values
$records = array();
$resultCount = 0;
$refKey = null;

$jsonData = $this->getResponseContent();

if ($this->isValidResponse($jsonData)) {
$searchResultData = $jsonData['searchResult'];
$refKey = $searchResultData['refKey'];

if (!empty($searchResultData['records']))
{
Expand All @@ -168,7 +166,6 @@ class Search extends AbstractAdapter
return FF::getInstance(
'Data\Result',
$records,
$refKey,
$resultCount
);
}
Expand Down
63 changes: 35 additions & 28 deletions docs/files/Adapter/Tracking.php.txt
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,24 @@ class Tracking extends AbstractAdapter
* not available, it will try to use session_id() to fetch one.
*
* @param string $sid session id
* @param string $userId id of user
* @return bool Success?
*/
public function doTrackingFromRequest($sid = null)
public function doTrackingFromRequest($sid = null, $userId = null)
{
$this->setupTrackingFromRequest($sid);
$this->setupTrackingFromRequest($sid, $userId);
return $this->applyTracking();
}

/**
* Use this method directly if you want to separate the setup from sending
* the request. This is particularly useful when using the
* MultiCurlRequestFactory.
*
* @param string $sid session id
* @param string $userId id of user
*/
public function setupTrackingFromRequest($sid = null)
public function setupTrackingFromRequest($sid = null, $userId = null)
{
if (strlen($sid) > 0)
$this->parameters['sid'] = $sid;
Expand All @@ -63,6 +67,9 @@ class Tracking extends AbstractAdapter
) {
$this->parameters['sid'] = session_id();
}

if (strlen($userId) > 0)
$this->parameters['userId'] = $userId;
}

/**
Expand All @@ -80,7 +87,7 @@ class Tracking extends AbstractAdapter
* @param string $title title of product (optional - is empty by default)
* @param int $pageSize size of the page where the product was found (optional - is 12 by default)
* @param int $origPageSize original size of the page before the user could have changed it (optional - is set equals to $page by default)
* @param string $userid id of user (optional if modul personalisation is not used)
* @param string $userId id of user (optional if modul personalisation is not used)
* @return boolean $success
*/
public function trackClick(
Expand All @@ -96,10 +103,10 @@ class Tracking extends AbstractAdapter
$title = '',
$pageSize = 12,
$origPageSize = -1,
$userid = null
$userId = null
) {
$this->setupClickTracking($id, $query, $pos, $masterId, $sid, $cookieId, $origPos, $page,
$simi, $title, $pageSize, $origPageSize, $userid);
$simi, $title, $pageSize, $origPageSize, $userId);
return $this->applyTracking();
}

Expand All @@ -121,7 +128,7 @@ class Tracking extends AbstractAdapter
$title = '',
$pageSize = 12,
$origPageSize = -1,
$userid = null
$userId = null
) {
if (strlen($sid) == 0) $sid = session_id();
if ($origPos == -1) $origPos = $pos;
Expand All @@ -140,7 +147,7 @@ class Tracking extends AbstractAdapter
'origPageSize' => $origPageSize,
);

if (strlen($userid) > 0) $params['userId'] = $userid;
if (strlen($userId) > 0) $params['userId'] = $userId;
if (strlen($cookieId) > 0) $params['cookieId'] = $cookieId;
if (strlen($masterId) > 0) $params['masterId'] = $masterId;

Expand All @@ -159,7 +166,7 @@ class Tracking extends AbstractAdapter
* @param string $cookieId cookie id (optional)
* @param int $count number of items purchased for each product (optional - default 1)
* @param float $price this is the single unit price (optional)
* @param string $userid id of user (optional if modul personalisation is not used)
* @param string $userId id of user (optional if modul personalisation is not used)
* @return boolean $success
*/
public function trackCart(
Expand All @@ -171,9 +178,9 @@ class Tracking extends AbstractAdapter
$cookieId = null,
$count = 1,
$price = null,
$userid = null
$userId = null
) {
$this->setupCartTracking($id, $masterId, $title, $query, $sid, $cookieId, $count, $price, $userid);
$this->setupCartTracking($id, $masterId, $title, $query, $sid, $cookieId, $count, $price, $userId);
return $this->applyTracking();
}

Expand All @@ -191,7 +198,7 @@ class Tracking extends AbstractAdapter
$cookieId = null,
$count = 1,
$price = null,
$userid = null
$userId = null
) {
if (strlen($sid) == 0) $sid = session_id();
$params = array(
Expand All @@ -203,7 +210,7 @@ class Tracking extends AbstractAdapter
);

if (strlen($price) > 0) $params['price'] = $price;
if (strlen($userid) > 0) $params['userId'] = $userid;
if (strlen($userId) > 0) $params['userId'] = $userId;
if (strlen($cookieId) > 0) $params['cookieId'] = $cookieId;
if (strlen($masterId) > 0) $params['masterId'] = $masterId;
if (strlen($query) > 0) $params['query'] = $query;
Expand All @@ -223,7 +230,7 @@ class Tracking extends AbstractAdapter
* @param string $cookieId cookie id (optional)
* @param int $count number of items purchased for each product (optional - default 1)
* @param float $price this is the single unit price (optional)
* @param string $userid id of user (optional if modul personalisation is not used)
* @param string $userId id of user (optional if modul personalisation is not used)
* @return boolean $success
*/
public function trackCheckout(
Expand All @@ -235,9 +242,9 @@ class Tracking extends AbstractAdapter
$cookieId = null,
$count = 1,
$price = null,
$userid = null
$userId = null
) {
$this->setupCheckoutTracking($id, $masterId, $title, $query, $sid, $cookieId, $count, $price, $userid);
$this->setupCheckoutTracking($id, $masterId, $title, $query, $sid, $cookieId, $count, $price, $userId);
return $this->applyTracking();
}

Expand All @@ -255,7 +262,7 @@ class Tracking extends AbstractAdapter
$cookieId = null,
$count = 1,
$price = null,
$userid = null
$userId = null
) {
if (strlen($sid) == 0) $sid = session_id();
$params = array(
Expand All @@ -268,7 +275,7 @@ class Tracking extends AbstractAdapter
);

if (strlen($price) > 0) $params['price'] = $price;
if (strlen($userid) > 0) $params['userId'] = $userid;
if (strlen($userId) > 0) $params['userId'] = $userId;
if (strlen($cookieId) > 0) $params['cookieId'] = $cookieId;
if (strlen($query) > 0) $params['query'] = $query;
if (strlen($masterId) > 0) $params['masterId'] = $masterId;
Expand All @@ -285,7 +292,7 @@ class Tracking extends AbstractAdapter
* @param string $masterId master id of the product (see field with the role "Master article number")
* @param string $sid session id (if empty, then try to set using the function session_id() )
* @param string $cookieId cookie id (optional)
* @param string $userid id of user (optional if modul personalisation is not used)
* @param string $userId id of user (optional if modul personalisation is not used)
* @return boolean $success
*/
public function trackRecommendationClick(
Expand All @@ -294,9 +301,9 @@ class Tracking extends AbstractAdapter
$masterId = null,
$sid = null,
$cookieId = null,
$userid = null
$userId = null
) {
$this->setupRecommendationClickTracking($id, $mainId, $masterId, $sid, $cookieId, $userid);
$this->setupRecommendationClickTracking($id, $mainId, $masterId, $sid, $cookieId, $userId);
return $this->applyTracking();
}

Expand All @@ -311,7 +318,7 @@ class Tracking extends AbstractAdapter
$masterId = null,
$sid = null,
$cookieId = null,
$userid = null
$userId = null
) {
if (strlen($sid) == 0) $sid = session_id();
$params = array(
Expand All @@ -323,7 +330,7 @@ class Tracking extends AbstractAdapter
'event' => 'recommendationClick'
);

if (strlen($userid) > 0) $params['userId'] = $userid;
if (strlen($userId) > 0) $params['userId'] = $userId;
if (strlen($cookieId) > 0) $params['cookieId'] = $cookieId;
if (strlen($masterId) > 0) $params['masterId'] = $masterId;

Expand All @@ -336,15 +343,15 @@ class Tracking extends AbstractAdapter
*
* @param string $sid session id (if empty, then try to set using the function session_id() )
* @param string $cookieId cookie id (optional)
* @param string $userid id of user who logged in
* @param string $userId id of user who logged in
* @return boolean $success
*/
public function trackLogin(
$sid = null,
$cookieId = null,
$userid = null
$userId = null
) {
$this->setupLoginTracking($sid, $cookieId, $userid);
$this->setupLoginTracking($sid, $cookieId, $userId);
return $this->applyTracking();
}

Expand All @@ -356,12 +363,12 @@ class Tracking extends AbstractAdapter
public function setupLoginTracking(
$sid = null,
$cookieId = null,
$userid = null
$userId = null
) {
if (strlen($sid) == 0) $sid = session_id();
$params = array(
'sid' => $sid,
'userId' => $userid,
'userId' => $userId,
'event' => 'login'
);

Expand Down
Loading

0 comments on commit fbea6c2

Please sign in to comment.