Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building #24

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Building #24

merged 4 commits into from
Apr 23, 2020

Conversation

jmattheis
Copy link
Contributor

Related: #23

Only needed for debugging.
The dependency is used to build ui before snage.
But not needed in the actual prod build.
@jmattheis jmattheis requested a review from tvrg April 23, 2020 11:38
@codecov-io
Copy link

Codecov Report

Merging #24 into master will decrease coverage by 40.38%.
The diff coverage is 6.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #24       +/-   ##
===========================================
- Coverage   78.79%   38.41%   -40.39%     
===========================================
  Files           5       17       +12     
  Lines         283      617      +334     
  Branches       69      137       +68     
===========================================
+ Hits          223      237       +14     
- Misses         59      379      +320     
  Partials        1        1               
Impacted Files Coverage Δ
packages/snage/src/command/create.ts 0.00% <0.00%> (ø)
packages/snage/src/command/init.ts 0.00% <0.00%> (ø)
packages/snage/src/command/lint.ts 0.00% <0.00%> (ø)
packages/snage/src/command/serve.ts 0.00% <0.00%> (ø)
packages/snage/src/config/load.ts 0.00% <0.00%> (ø)
packages/snage/src/create/changelogFileWriter.ts 0.00% <0.00%> (ø)
packages/snage/src/create/consoleParamsReader.ts 0.00% <0.00%> (ø)
packages/snage/src/create/consoleWizzard.ts 0.00% <0.00%> (ø)
packages/snage/src/create/dateProvider.ts 0.00% <0.00%> (ø)
packages/snage/src/create/genChangelog.ts 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5df27e...fa8be4d. Read the comment docs.

packages/ui/package.json Show resolved Hide resolved
packages/snage/webpack.common.js Show resolved Hide resolved
packages/snage/package.json Show resolved Hide resolved
@tvrg
Copy link
Contributor

tvrg commented Apr 23, 2020

Wie wird ein neues Artefakt nach npm gepusht? Das machen wir erst mal manuell? Soll das langfristig per github-action laufen?

@jmattheis jmattheis merged commit 48bc184 into master Apr 23, 2020
@jmattheis jmattheis deleted the building branch April 23, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants