Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automagically verify URLs in documentation #6352

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Jul 15, 2024

Description of the proposed changes

Extends upon #6351

@Garanas Garanas changed the title Docs/ url checker 02 Automagically verify URLs in documentation Jul 15, 2024
@Garanas
Copy link
Member Author

Garanas commented Jul 15, 2024

I'm not a huge fan of the setup of this Action. The repository is:

And one may notice that the source code is not in this repository. It is actually retrieved via the Docker image, found at:

And all the GitHub Action is a wrapper to call the Python in that Docker image. The source code of the actual tool can be found here:

I understand the setup, but not having the source code in the GitHub Action itself feels a little sketchy 🤔 ?

@Garanas Garanas merged commit 62e3a21 into develop Jul 15, 2024
4 checks passed
@Garanas Garanas deleted the docs/-url-checker-02 branch July 15, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant