Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Seraphim sniper's barrel not aiming with LOD1 model #6622

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Jan 15, 2025

Description of the proposed changes

  • Renames the vertex group/bone responsible for the barrel vertices from lod1_Barrel to Barrel

Testing done on the proposed changes

The barrel can be seen rotating when zoomed out:

{B222C165-5952-496E-BEB0-8CC8789D7C42}

Freecam can help hide the strategic icon if it obscures your view.

Checklist

- [ ] Changes are annotated, including comments where useful

  • Changes are documented in the changelog for the next game version

lod1_Barrel -> Barrel
This fixes the turret not rotating the barrel
@lL1l1 lL1l1 added type: bug area: graphics Anything Related to the Game Graphics labels Jan 15, 2025
@lL1l1 lL1l1 added this to the Development Iteration I of 2025 milestone Jan 15, 2025
@lL1l1 lL1l1 marked this pull request as ready for review January 15, 2025 06:34
@lL1l1
Copy link
Contributor Author

lL1l1 commented Jan 15, 2025

I don't know how to verify all the other models or if there are any other known similar issues, since this was quite a human mistake that is likely to be repeated somewhere.

Also not sure where to document this behavior of turrets and LOD models.

Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delivers as promised. I also noticed this, but I had no idea how to fix it.

With regards to documentation, maybe this should be on the wiki. For example:

@Garanas Garanas merged commit cdc082c into FAForever:develop Jan 25, 2025
5 checks passed
@lL1l1
Copy link
Contributor Author

lL1l1 commented Jan 25, 2025

I added a note about LoDs on that wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Anything Related to the Game Graphics type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants