Add a delay to the pause feature

[Garanas]

Description of the proposed changes

Related to:

• https://forum.faforever.com/topic/8648/suggesting-rule-change-make-immediately-unpausing-after-a-player-asked-for-a-pause-against-the-rules/1

Introduces a small delay before user A can resume the session after a pause initiated by user B. At all times, user B can resume immediately. A chat message is posted when a user pauses the session, attempts to resume the session and when the session is resumed.

Testing done on the proposed changes

Launched the game directly into the match maker lobby with the LaunchScripts made by @lL1l1 .

Checklist

• Changes are annotated, including comments where useful
• Changes are documented in the changelog for the next game version

[Garanas]

Adjusted the chat message to include the number of seconds until the user can resume the game:

[lL1l1]

I get the following error when unpausing:

WARNING: Error running '/lua/ui/game/gamemain.lua:ReceiveChat': ...\lua\ui\game\gamemain.lua(747): access to nonexistent global variable "SendResumedBy"
         stack traceback:
         	[C]: in function `error'
         	...\lua\system\config.lua(58): in function <...\lua\system\config.lua:57>
         	...\lua\ui\game\gamemain.lua(747): in function `func'
         	...\lua\ui\game\gamemain.lua(1082): in function <...\lua\ui\game\gamemain.lua:1066>

The debug logging should be removed too.

The rest of the general functionality of the unpause delay works in my testing.

[lL1l1]

I do not think this hook is necessary. Shouldn't the nonsensical case be handled by the engine already?

[4z0t]

I do not think this hook is necessary. Shouldn't the nonsensical case be handled by the engine already?

I'll check this evening.

[Garanas]

If I am not mistaken then the message would be sent and it would override the person who initiated the pause.

[4z0t]

Had to add that before, but I'll say then now: change these messages (pause/unpause/want to continue) to notification messages. Meaning that message is not typed by a player, but rather provided by a system.

[Garanas]

Is there an existing system for this? If not, then it's out of scope of this particular pull request in my opinion.

[4z0t]

There is one that is used for notifications, such as HQ upgrades and ACU enhancements.

[Garanas]

There is one that is used for notifications, such as HQ upgrades and ACU enhancements.

That is Notify, which originates from the sim if I am not mistaken.

[Garanas]

@lL1l1 I think I processed your feedback.