-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow API access to Elide for services without user authentication #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #802 +/- ##
=============================================
- Coverage 78.28% 78.18% -0.10%
- Complexity 1248 1254 +6
=============================================
Files 242 244 +2
Lines 3776 3805 +29
Branches 241 241
=============================================
+ Hits 2956 2975 +19
- Misses 715 724 +9
- Partials 105 106 +1
Continue to review full report in Codecov by Sentry.
|
b55a393
to
c4d6d21
Compare
will try to add some tests |
c4d6d21
to
4828ec1
Compare
Sheikah45
reviewed
Nov 24, 2023
src/main/java/com/faforever/api/security/FafAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/api/security/FafServiceAuthenticationToken.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/api/security/FafUserAuthenticationToken.java
Outdated
Show resolved
Hide resolved
4828ec1
to
a536eb9
Compare
Brutus5000
reviewed
Nov 26, 2023
6abf569
to
92af93b
Compare
92af93b
to
9f50171
Compare
Brutus5000
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #793 Allow API access to Elide for services without user authentication