Skip to content

Commit

Permalink
fix credential vending document
Browse files Browse the repository at this point in the history
  • Loading branch information
FANNG1 committed Jan 17, 2025
1 parent adce82a commit 6d29ccb
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ on:
required: true
type: string
latest:
description: 'whether publish the image to docker latest tag, only used for offical release, don't use it for RC'
description: 'Whether to publish the image to the Docker latest tag. This operation is only applicable to official releases and should not be used for Release Candidate (RC) polishing.'
required: false
type: boolean
default: false
Expand Down Expand Up @@ -89,6 +89,12 @@ jobs:
echo "image_name=apache/gravitino-iceberg-rest" >> $GITHUB_ENV
fi
if [ "${{ github.event.inputs.latest }}" == "true" ]; then
echo "publish_latest=true" >> $GITHUB_ENV
else
echo "publish_latest=false" >> $GITHUB_ENV
fi

- name: Check publish Docker token
run: |
if [[ "${secrets_token}" != "${input_token}" ]]; then
Expand Down Expand Up @@ -120,7 +126,7 @@ jobs:
sudo rm -rf /usr/local/lib/android
sudo rm -rf /opt/hostedtoolcache/CodeQL
if [[ "${image_type}" == "gravitino" || "${image_type}" == "iceberg-rest-server" || "${{ github.event.inputs.latest }}" == "true" ]]; then
if [[ "${image_type}" == "gravitino" || "${image_type}" == "iceberg-rest-server" || "${publish_latest}" == "true" ]]; then
echo "latest"
#./dev/docker/build-docker.sh --platform all --type ${image_type} --image ${image_name} --tag ${{ github.event.inputs.version }} --latest
else
Expand Down

0 comments on commit 6d29ccb

Please sign in to comment.