Fixes fprem #4101
Merged
Fixes fprem #4101
+111
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign-in to steam worked on the first try (M1 Ultra/Fedora 41/FEX 2409 + this PR) |
fixes incorrect signs on FPREM. in turn should fix end-to-end failures logging into Steam. Thank you to Sergio Lopez for tracking down the JavaScript fail, and Ryan for finding the bug. Signed-off-by: Alyssa Rosenzweig <[email protected]>
Exposes a bug in FEX's x87 FPREM implementation.
Sonicadvance1
force-pushed
the
fprem_fixes
branch
from
6b6d69d
to
16869d8
Compare
|
This also fixes #3685, I just gave it a test. |
alyssarosenzweig
approved these changes
Oct 3, 2024
|
Wow - nice catch! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.