Allow promotion of geometry dimension for built-in mesh creators. #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will now do the work on the C++ interface to get this parameter up to |
jorgensd
reviewed
Oct 15, 2024
| @@ -72,7 +72,7 @@ refine(const mesh::Mesh<T>& mesh, | |||
|
|
|||
| mesh::Mesh<T> mesh1 = mesh::create_mesh( | |||
| mesh.comm(), mesh.comm(), cell_adj.array(), mesh.geometry().cmap(), | |||
| mesh.comm(), new_vertex_coords, xshape, partitioner); | |||
| mesh.comm(), new_vertex_coords, xshape, mesh.geometry().dim(), partitioner); | |||
There was a problem hiding this comment.
Shouldn’t xshape[1] and mesh.geometry().dim() be the same?
There was a problem hiding this comment.
Yes - but in terms of the code being correct in meaning, the former is the shape of the geometry data and the latter is the geometric dimension.
There was a problem hiding this comment.
Do we check if they match? We should probably add some sanity checks.
…olfinx into jhale/add-gdim-to-mesh-creators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no easy way to create e.g. a unit interval living in 2d or
3d geometric space.
After discussion of this implementation I will implement the others the same way.