Add corner case where the description from a data type profile used in a derived profile isn't used

[pieter-edelman-nictiz]

No description provided.

[grahamegrieve]

Where does this sit with regard to https://chat.fhir.org/#narrow/channel/215610-shorthand/topic/IG.20publisher.20overwriting.20element.20description ?

[pieter-edelman-nictiz]

It's a bit different (and admittedly, a bit involved).

• First, there's a 'zib' layer with a profile that uses a data type profile. My expectation here would be that the profile renders the description from the data type profile (which is indeed the case).
• Then there's an 'nl-core' layer, where the original profile is derived. In this derived profile, the original use of the data type profile is overwritten by the use of another data type profile, with another description. My expectation is that the derived profile renders the description from the overwriting data type profile instead of the original data type profile. This is currently not the case for the Validator.

[grahamegrieve]

So I expected that after I merged this, the test would fail until I fixed the actual snapshot code, but no?

[pieter-edelman-nictiz]

So I expected that after I merged this, the test would fail until I fixed the actual snapshot code, but no?

It doesn't fail? That's weird. If I create a snapshot using the latest version of the Validator (6.4.4), the comment on CarePlan.contributor:requester in the snapshot is the comment from the 'zib' data type profile. I've manually adjusted this in "nl-core-NursingIntervention-output.json" to the comment from the 'nl-core' data type profile as the desired behavior.

[grahamegrieve]

well, where's the specific bit in the expected outcome that you changed?

[pieter-edelman-nictiz]

In two places, see these screenshots. On the left is the output as produced by the Validator, on the right is the output in this PR.

[pieter-edelman-nictiz]

Note: conversion was done using -version 4.0.1

[grahamegrieve]

can you look at this: #203

which of these changes are pertinent to the test case?

[pieter-edelman-nictiz]

I added pull request comments