fix 2 ?

[grahamegrieve]

No description provided.

[grahamegrieve]

@pieter-edelman-nictiz same deal - I think I have the test setup correctly now, so where is it wrong?

[pieter-edelman-nictiz]

The comment on CarePlan.contributor:requester (line 1320) and on CarePlan.activity.detail.performer:healthcareProvider (line 4088). The expected result is that it is the comment from the data type profile used (pattern-NlCoreHealthProfessionalReference), but the actual result in this PR is that it is the comment from the data type profile used in the parent profile (pattern-ZibHealthProfessionalReference).

[grahamegrieve]

well, let's stick with zib-NursingIntervention/CarePlan.contributor:requestor - in the snapshot for that, comment is "Collaborative care plans may have multiple contributors." And then it's still the same in nl-core-NursingIntervention/CarePlan.contributor:requestor - so in that case it's simple, it's not picking up the comments from the data type profile at all?

[pieter-edelman-nictiz]

well, let's stick with zib-NursingIntervention/CarePlan.contributor:requestor - in the snapshot for that, comment is "Collaborative care plans may have multiple contributors." And then it's still the same in nl-core-NursingIntervention/CarePlan.contributor:requestor - so in that case it's simple, it's not picking up the comments from the data type profile at all?

I didn't look at the snapshot of zib-NursingIntervention before, but it seems like you're right, the comment from the data type profile is not picked up in the snapshot.

What's weird is that the comment from this snapshot does end up in the profile derived from zib-NursingIntervention.

[grahamegrieve]

the comment from this snapshot does end up in the profile derived from zib-NursingIntervention.

not sure what you mean, or where. it's the base comment all the way

[pieter-edelman-nictiz]

Ok, I guess we're doing some pretty funky profiling here. So the chain of profiles looks like this:

flowchart LR
    CarePlan -- profile --> zib-NursingIntervention
    zib-NursingIntervention -- profile --> nl-core-NursingIntervention-input
    pattern-ZibHealthProfessionalReference[pattern-ZibHealthProfessionalReference
    _overrides comment in host profile_]
    pattern-NlcoreHealthProfessionalReference[pattern-NlcoreHealthProfessionalReference
    _**again** overrides comment in host profile_]
    subgraph zib
        zib-NursingIntervention -- uses on Careplan.contributor:requester --- pattern-ZibHealthProfessionalReference
    end
    subgraph nl-core
        nl-core-NursingIntervention-input -- uses on Careplan.contributor:requester --- pattern-NlcoreHealthProfessionalReference
    end
    nl-core-NursingIntervention-input -- snapshot generation --> nl-core-NursingIntervention-output
    nl-core-NursingIntervention-output[nl-core-NursingIntervention-ouput
    _should contain comment from pattern-NlcoreHealthProfessionalReference_ on CarePlan.contributor:requester]

Loading

I create the snapshot using the following command:

java -jar validator_cli.jar -ig snapshot-generation/ -version 4.0.1 -tx n/a -snapshot -outputSuffix snapshot.json snapshot-generation/nl-core-NursingIntervention-input.xml

And then rename nl-core-NursingIntervention-input.xml.snapshot.json to nl-core-NursingIntervention-output.json.

If I now inspect nl-core-NursingIntervention-output.json, element CarePlan.contributor:requester, I would expect to see the comment from pattern-NlcoreHealthProfessionalReference, but instead I'm seeing the comment from pattern-ZibHealthProfessionalReference.