Whenever we log an arbitrary error.message, debug log its stack

FHIR · Aug 24, 2023 · f94852c · f94852c
1 parent b674857
commit f94852c
Show file tree

Hide file tree

Showing 13 changed files with 135 additions and 10 deletions.
diff --git a/src/app.ts b/src/app.ts
@@ -38,6 +38,9 @@ const FSH_VERSION = '3.0.0-ballot';
 
 function logUnexpectedError(e: Error) {
   logger.error(`SUSHI encountered the following unexpected error: ${e.message}`);
+  if (e.stack) {
+    logger.debug(e.stack);
+  }
   process.exit(1);
 }
 
@@ -243,6 +246,9 @@ async function runBuild(input: string, program: OptionValues, helpText: string)
     // If no errors have been logged yet, log this exception so the user knows why we're exiting
     if (stats.numError === 0) {
       logger.error(`An unexpected error occurred: ${e.message ?? e}`);
+      if (e.stack) {
+        logger.debug(e.stack);
+      }
     }
     process.exit(1);
   }

diff --git a/src/export/CodeSystemExporter.ts b/src/export/CodeSystemExporter.ts
@@ -111,6 +111,9 @@ export class CodeSystemExporter {
         }
       } catch (e) {
         logger.error(e.message, rule.sourceInfo);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       }
     });
     resolveSoftIndexing(successfulRules);
@@ -147,6 +150,9 @@ export class CodeSystemExporter {
           assignInstanceFromRawValue(codeSystem, rule, instanceExporter, this.fisher, originalErr);
         } else {
           logger.error(originalErr.message, rule.sourceInfo);
+          if (originalErr.stack) {
+            logger.debug(originalErr.stack);
+          }
         }
       }
     }
@@ -246,6 +252,9 @@ export class CodeSystemExporter {
         this.exportCodeSystem(cs);
       } catch (e) {
         logger.error(e.message, cs.sourceInfo);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       }
     }
     if (codeSystems.length > 0) {

diff --git a/src/export/InstanceExporter.ts b/src/export/InstanceExporter.ts
@@ -208,19 +208,31 @@ export class InstanceExporter implements Fishable {
           const instanceToAssign = this.fishForFHIR(rule.rawValue);
           if (instanceToAssign == null) {
             logger.error(originalErr.message, rule.sourceInfo);
+            if (originalErr.stack) {
+              logger.debug(originalErr.stack);
+            }
           } else {
             try {
               doRuleValidation(instanceToAssign);
             } catch (instanceErr) {
               if (instanceErr instanceof MismatchedTypeError) {
                 logger.error(originalErr.message, rule.sourceInfo);
+                if (originalErr.stack) {
+                  logger.debug(originalErr.stack);
+                }
               } else {
                 logger.error(instanceErr.message, rule.sourceInfo);
+                if (instanceErr.stack) {
+                  logger.debug(instanceErr.stack);
+                }
               }
             }
           }
         } else {
           logger.error(originalErr.message, rule.sourceInfo);
+          if (originalErr.stack) {
+            logger.debug(originalErr.stack);
+          }
         }
       }
     });
@@ -853,6 +865,9 @@ export class InstanceExporter implements Fishable {
         this.exportInstance(instance);
       } catch (e) {
         logger.error(e.message, instance.sourceInfo);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       }
     }
     this.warnOnInstanceOfCustomResource();

diff --git a/src/export/MappingExporter.ts b/src/export/MappingExporter.ts
@@ -50,6 +50,9 @@ export class MappingExporter {
           element.applyMapping(fshDefinition.id, rule.map, rule.comment, rule.language);
         } catch (e) {
           logger.error(e.message, rule.sourceInfo);
+          if (e.stack) {
+            logger.debug(e.stack);
+          }
         }
       } else {
         logger.error(
@@ -131,6 +134,9 @@ export class MappingExporter {
         this.exportMapping(mapping);
       } catch (e) {
         logger.error(e.message, mapping.sourceInfo);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       }
     }
     // The mappings on each Structure Definition should have a unique id

diff --git a/src/export/StructureDefinitionExporter.ts b/src/export/StructureDefinitionExporter.ts
@@ -738,6 +738,9 @@ export class StructureDefinitionExporter implements Fishable {
           }
         } catch (e) {
           logger.error(e.message, rule.sourceInfo);
+          if (e.stack) {
+            logger.debug(e.stack);
+          }
         }
         continue;
       }
@@ -848,6 +851,9 @@ export class StructureDefinitionExporter implements Fishable {
                   element.addSlice(item.name);
                 } catch (e) {
                   logger.error(e.message, rule.sourceInfo);
+                  if (e.stack) {
+                    logger.debug(e.stack);
+                  }
                 }
               });
             }
@@ -926,6 +932,9 @@ export class StructureDefinitionExporter implements Fishable {
           }
         } catch (e) {
           logger.error(e.message, rule.sourceInfo);
+          if (e.stack) {
+            logger.debug(e.stack);
+          }
         }
       } else {
         logger.error(
@@ -961,13 +970,22 @@ export class StructureDefinitionExporter implements Fishable {
           } catch (e) {
             if (e instanceof MismatchedTypeError && originalErr != null) {
               logger.error(originalErr.message, rule.sourceInfo);
+              if (originalErr.stack) {
+                logger.debug(originalErr.stack);
+              }
             } else {
               logger.error(e.message, rule.sourceInfo);
+              if (e.stack) {
+                logger.debug(e.stack);
+              }
             }
           }
         } else {
           if (originalErr != null) {
             logger.error(originalErr.message, rule.sourceInfo);
+            if (originalErr.stack) {
+              logger.debug(originalErr.stack);
+            }
           } else {
             logger.error(`Could not find a resource named ${rule.value}`, rule.sourceInfo);
           }
@@ -1020,11 +1038,17 @@ export class StructureDefinitionExporter implements Fishable {
             const slice = element.getSlices().find(el => el.sliceName === item.name);
             if (slice?.type[0]?.profile?.some(p => p === extension.url)) {
               logger.warn(e.message, rule.sourceInfo);
+              if (e.stack) {
+                logger.debug(e.stack);
+              }
               return;
             }
           }
           // Otherwise it is a conflicting duplicate extension or some other error
           logger.error(e.message, rule.sourceInfo);
+          if (e.stack) {
+            logger.debug(e.stack);
+          }
         }
         // check if we have used modifier extensions correctly
         const isModifier = isModifierExtension(extension);
@@ -1061,6 +1085,9 @@ export class StructureDefinitionExporter implements Fishable {
           // as inline extensions require further definition outside of the contains rule, so
           // there is more likely to be conflict, and detecting such conflict is more difficult.
           logger.error(e.message, rule.sourceInfo);
+          if (e.stack) {
+            logger.debug(e.stack);
+          }
         }
       }
     });
@@ -1350,6 +1377,9 @@ export class StructureDefinitionExporter implements Fishable {
         this.exportStructDef(sd);
       } catch (e) {
         logger.error(e.message, e.sourceInfo || sd.sourceInfo);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       }
     });
     this.warnOnNonConformantResourceDefinitions();

diff --git a/src/export/ValueSetExporter.ts b/src/export/ValueSetExporter.ts
@@ -205,6 +205,9 @@ export class ValueSetExporter {
           assignInstanceFromRawValue(valueSet, rule, instanceExporter, this.fisher, originalErr);
         } else {
           logger.error(originalErr.message, rule.sourceInfo);
+          if (originalErr.stack) {
+            logger.debug(originalErr.stack);
+          }
         }
       }
     }
@@ -293,6 +296,9 @@ export class ValueSetExporter {
         this.exportValueSet(valueSet);
       } catch (e) {
         logger.error(e.message, valueSet.sourceInfo);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       }
     }
     if (valueSets.length > 0) {

diff --git a/src/fhirdefs/load.ts b/src/fhirdefs/load.ts
@@ -78,6 +78,9 @@ export function loadCustomResources(
             continue;
           }
           logger.error(`Loading ${file} failed with the following error:\n${e.message}`);
+          if (e.stack) {
+            logger.debug(e.stack);
+          }
           continue;
         }
         // All resources are added to the predefined map, so that this map can later be used to
@@ -125,5 +128,8 @@ export async function loadSupplementalFHIRPackage(
     .then((def: FHIRDefinitions) => defs.addSupplementalFHIRDefinitions(fhirPackage, def))
     .catch((e: Error) => {
       logger.error(`Failed to load supplemental FHIR package ${fhirPackage}: ${e.message}`);
+      if (e.stack) {
+        logger.debug(e.stack);
+      }
     });
 }
diff --git a/src/fhirtypes/common.ts b/src/fhirtypes/common.ts
@@ -1491,6 +1491,9 @@ export function assignInstanceFromRawValue(
   const instance = instanceExporter.fishForFHIR(rule.rawValue);
   if (instance == null) {
     logger.error(originalErr.message, rule.sourceInfo);
+    if (originalErr.stack) {
+      logger.debug(originalErr.stack);
+    }
   } else {
     try {
       setPropertyOnDefinitionInstance(
@@ -1502,8 +1505,14 @@ export function assignInstanceFromRawValue(
     } catch (instanceErr) {
       if (instanceErr instanceof MismatchedTypeError) {
         logger.error(originalErr.message, rule.sourceInfo);
+        if (originalErr.stack) {
+          logger.debug(originalErr.stack);
+        }
       } else {
         logger.error(instanceErr.message, rule.sourceInfo);
+        if (instanceErr.stack) {
+          logger.debug(instanceErr.stack);
+        }
       }
     }
   }

diff --git a/src/import/FSHImporter.ts b/src/import/FSHImporter.ts
@@ -247,6 +247,9 @@ export class FSHImporter extends FSHVisitor {
       } catch (err) {
         const sourceInfo = { location: this.extractStartStop(e), file: this.currentFile };
         logger.error(`Error in parsing: ${err.message}`, sourceInfo);
+        if (err.stack) {
+          logger.debug(err.stack);
+        }
       }
     });
   }
@@ -444,6 +447,9 @@ export class FSHImporter extends FSHVisitor {
         this.currentDoc.instances.set(instance.name, instance);
       } catch (e) {
         logger.error(e.message, instance.sourceInfo);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       }
     }
   }

diff --git a/src/import/importConfiguration.ts b/src/import/importConfiguration.ts
@@ -79,6 +79,9 @@ export function importConfiguration(yaml: YAMLConfiguration | string, file: stri
       parsed = YAML.parse(yaml);
     } catch (e) {
       logger.error(`Error parsing configuration: ${e.message}.`, { file });
+      if (e.stack) {
+        logger.debug(e.stack);
+      }
       throw new Error('Invalid configuration YAML');
     }
     if (typeof parsed !== 'object' || parsed === null) {

diff --git a/src/utils/PathUtils.ts b/src/utils/PathUtils.ts
@@ -231,6 +231,9 @@ export function resolveSoftIndexing(rules: Array<Rule | CaretValueRule>, strict
         }
       } catch (e) {
         logger.error(e.message, originalRule.sourceInfo);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       }
     });
     originalRule.path = assembleFSHPath(parsedRule.path); // Assembling the separated rule path back into a normal string
@@ -257,6 +260,9 @@ export function resolveSoftIndexing(rules: Array<Rule | CaretValueRule>, strict
         }
       } catch (e) {
         logger.error(e.message, originalRule.sourceInfo);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       }
     });
 

diff --git a/src/utils/Processing.ts b/src/utils/Processing.ts
@@ -169,6 +169,9 @@ export function ensureOutputDir(input: string, output: string): string {
       logger.error(
         `Unable to empty existing fsh-generated folder because of the following error: ${e.message}`
       );
+      if (e.stack) {
+        logger.debug(e.stack);
+      }
     }
   }
   return outDir;
@@ -369,6 +372,9 @@ export async function loadAutomaticDependencies(
           message += CERTIFICATE_MESSAGE;
         }
         logger.warn(message);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       }
     }
   }
@@ -417,6 +423,9 @@ async function loadConfiguredDependencies(
           message += CERTIFICATE_MESSAGE;
         }
         logger.error(message);
+        if (e.stack) {
+          logger.debug(e.stack);
+        }
       });
     }
   }
@@ -703,6 +712,9 @@ export async function init(): Promise<void> {
       }
     } catch (e) {
       logger.error(`Unable to download ${script} from ${url}: ${e.message}`);
+      if (e.stack) {
+        logger.debug(e.stack);
+      }
     }
   }
   const maxLength = 32;
@@ -760,6 +772,9 @@ async function getLatestSushiVersionFallback(): Promise<string> {
     }
   } catch (e) {
     logger.warn(`Unable to determine the latest version of sushi: ${e.message}`);
+    if (e.stack) {
+      logger.debug(e.stack);
+    }
   }
 }
 
@@ -774,6 +789,9 @@ export async function getLatestSushiVersion(): Promise<string | undefined> {
     }
   } catch (e) {
     logger.info(`Unable to determine the latest version of sushi: ${e.message}`);
+    if (e.stack) {
+      logger.debug(e.stack);
+    }
   }
 
   if (latestVer === undefined) {