Skip to content

Commit

Permalink
Vulkan: Pair resource sets by stage, not by type
Browse files Browse the repository at this point in the history
  • Loading branch information
flibitijibibo committed May 21, 2024
1 parent ee3b0af commit 3e4ea7b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion MojoShader
4 changes: 2 additions & 2 deletions src/FNA3D_Driver_Vulkan.c
Original file line number Diff line number Diff line change
Expand Up @@ -4118,8 +4118,8 @@ static void VULKAN_INTERNAL_FetchDescriptorSetDataAndOffsets(
renderer->fragSamplerDescriptorSetDataNeedsUpdate = 0;

descriptorSets[0] = renderer->currentVertexSamplerDescriptorSet;
descriptorSets[1] = renderer->currentFragSamplerDescriptorSet;
descriptorSets[2] = vertShaderResources->uniformDescriptorSet;
descriptorSets[1] = vertShaderResources->uniformDescriptorSet;

This comment has been minimized.

Copy link
@kg

kg May 21, 2024

Contributor

should these indices use named constants?

This comment has been minimized.

Copy link
@flibitijibibo

flibitijibibo May 21, 2024

Author Member

Probably - might be worth adding to mojoshader.h once we're sure this won't need to be tweaked again later.

descriptorSets[2] = renderer->currentFragSamplerDescriptorSet;
descriptorSets[3] = fragShaderResources->uniformDescriptorSet;

MOJOSHADER_vkGetUniformBuffers(
Expand Down

0 comments on commit 3e4ea7b

Please sign in to comment.