Added a custom 404 not found page #210
Conversation
✅ Deploy Preview for fossc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you 🙏🏻 for contributing to progress-tracker by @FOSS-Community. Looking Forward for more contributions.
There was a problem hiding this comment.
Hey @parthrc , Thanks for the PR, there is an issue, the 404 Error Image is not rendering.
src/pages/PageNotFound.jsx
Outdated
| <div className="flex text-white flex-col items-center justify-center p-10"> | ||
| <img | ||
| className="w-96 mx-auto " | ||
| src="src\assets\img\page_not_found_img\404-error.png" |
There was a problem hiding this comment.
Change it to src="src/assets/img/page_not_found_img/404-error.png" to fix this error
|
@Mr-Sunglasses Hey, i did the changes. |
| @@ -0,0 +1,23 @@ | |||
| import { Link } from "react-router-dom"; | |||
|
|
|||
There was a problem hiding this comment.
So we need to import the image to render it instead of passing it directly to src
use this
import logo_404 from "./assets/img/page_not_found_img/error.png"
src/pages/PageNotFound.jsx
Outdated
| <div className="flex text-white flex-col items-center justify-center p-10"> | ||
| <img | ||
| className="w-96 mx-auto " | ||
| src="src/assets/img/page_not_found_img/error.png" |
There was a problem hiding this comment.
Change it to src={logo_404}
|
@Mr-Sunglasses seems to be fixed now, also working on netlify deploy preview |
There was a problem hiding this comment.
Awesome work @parthrc , 🍻 Thanks for solving this major issue 🙏🏻
|
@Mr-Sunglasses , thank you so much for the oppurtunity, this is my first ever open source contribution, hopefully many more to come 💯 |
Description
Added a custom "404 page not found" page. Issue #209. No dependencies required.
Fixes #209
Type of change