Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced Features #3

Merged
merged 17 commits into from
Jan 18, 2025
Merged

Enhanced Features #3

merged 17 commits into from
Jan 18, 2025

Conversation

KenwoodFox
Copy link
Member

@KenwoodFox KenwoodFox commented Jan 13, 2025 •
edited
Loading

@KenwoodFox KenwoodFox added the enhancement New feature or request label Jan 13, 2025
@KenwoodFox KenwoodFox added this to the battery.frc1721.org milestone Jan 13, 2025
@KenwoodFox KenwoodFox self-assigned this Jan 13, 2025
@gitguardian GitGuardian
Copy link

gitguardian bot commented Jan 13, 2025 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@KenwoodFox KenwoodFox changed the base branch from master to feat/automatedBuilds January 13, 2025 04:47
KenwoodFox added a commit that referenced this pull request Jan 13, 2025
@KenwoodFox
Merge pull request #1 from FRC-1721/feat/automatedBuilds
3aca415 
Forcing this through (sorry no review)

Future dev on #3
Base automatically changed from feat/automatedBuilds to master January 13, 2025 16:45
@KenwoodFox
Copy link
Member Author

If you go to /battery/<battery_id>
image
Theres a new button to print a label.

Takes you to /label/<battery_id> and generates a label like this
image

@KenwoodFox KenwoodFox linked an issue Jan 14, 2025 that may be closed by this pull request
Unauthorized users can use form submission #4
Closed
@KenwoodFox KenwoodFox marked this pull request as ready for review January 14, 2025 21:36
@KenwoodFox
Copy link
Member Author

KenwoodFox commented Jan 14, 2025 •
edited
Loading

This is ready for review @dublUayaychtee see live preview here https://devbattery.frc1721.org/

dublUayaychtee
dublUayaychtee approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@dublUayaychtee dublUayaychtee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

@dublUayaychtee dublUayaychtee merged commit 1f77eeb into master Jan 18, 2025
4 checks passed
@dublUayaychtee dublUayaychtee deleted the feat/enhanced-image-cards branch January 18, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dublUayaychtee dublUayaychtee dublUayaychtee approved these changes

Assignees

@KenwoodFox KenwoodFox

Labels
enhancement New feature or request
Projects
None yet
Milestone
battery.frc1721.org
Development

Successfully merging this pull request may close these issues.

Unauthorized users can use form submission
2 participants
@KenwoodFox @dublUayaychtee